fix(DatePicker): explicitly update minDate and maxDate #4912
Conversation
ghost
requested review from
|
Deploy preview for the-carbon-components ready! Built with commit fe9af26 https://deploy-preview-4912--the-carbon-components.netlify.com |
|
I think we can do that. I can wait for #4856 getting merged then add the change. |
|
Deploy preview for carbon-elements failed. Built with commit fe9af26 https://app.netlify.com/sites/carbon-elements/deploys/5e1504a58efe320008f2224b |
|
Deploy preview for carbon-components-react ready! Built with commit fe9af26 https://deploy-preview-4912--carbon-components-react.netlify.com |
Since flatpickr does not automatically update minDate and maxDate, we need to explicitly do it when the user makes any change in the props by using set(option, value) method from flatpickr
Since flatpickr does not automatically update minDate and maxDate, we need to explicitly do it when the user makes any change in the props by using set(option, value) method from flatpickr Aligned to the change in carbon-design-system#4856
figfofu
force-pushed
the
date_picker_update_minDate_maxDate
branch
from
d14d293
to
cc80a71
Compare
|
Thank you for the update @figfofu! Going through props with an array is an interesting approach, but I'd rather not abstracting that... Would it be OK for you to add the logic for BTW you can simply add comments once you add update commits and I'll get notified via email. |
Since flatpickr does not automatically update minDate and maxDate, we need to explicitly do it when the user makes any change in the props by using set(option, value) method from flatpickr Aligned to the change in carbon-design-system#4856
|
@asudoh |
…-system#4912) Since flatpickr does not automatically update minDate and maxDate, we need to explicitly do it when the user makes any change in the props by using set(option, value) method from flatpickr
…-system#4912) Since flatpickr does not automatically update minDate and maxDate, we need to explicitly do it when the user makes any change in the props by using set(option, value) method from flatpickr
Since flatpickr does not automatically update minDate and maxDate,
we need to explicitly do it when the user makes any change in the props
by using set(option, value) method from flatpickr
Fixes #2500
Changelog
New
Changed
Removed
Testing / Reviewing
Testing should make sure is not broken.