Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reflect "Operator tokens #601" in the design docs #1992

Closed
josh11b opened this issue Aug 11, 2022 · 4 comments · Fixed by #2657
Closed

Reflect "Operator tokens #601" in the design docs #1992

josh11b opened this issue Aug 11, 2022 · 4 comments · Fixed by #2657
Labels
good first issue Possibly a good first issue for newcomers long term Issues expected to take over 90 days to resolve.

Comments

@josh11b
Copy link
Contributor

josh11b commented Aug 11, 2022 •
edited
Loading

Proposal #601 was accepted but the design docs in https://github.com/carbon-language/carbon-lang/tree/trunk/docs/design/lexical_conventions have not been updated to reflect its acceptance.
@josh11b josh11b added the good first issue Possibly a good first issue for newcomers label Aug 11, 2022
Quzzar added a commit to Quzzar/carbon-lang that referenced this issue Aug 12, 2022
@Quzzar
Added doc for operators lexical elements (carbon-language#1992)
2fcd9a1
@github-actions
Copy link

We triage inactive PRs and issues in order to make it easier to find active work. If this issue should remain active or becomes active again, please comment or remove the inactive label. The long term label can also be added for issues which are expected to take time.
This issue is labeled inactive because the last activity was over 90 days ago.

@github-actions github-actions bot added the inactive Issues and PRs which have been inactive for at least 90 days. label Nov 10, 2022
@josh11b josh11b removed the inactive Issues and PRs which have been inactive for at least 90 days. label Nov 10, 2022
@josh11b
Copy link
Contributor Author

josh11b commented Nov 10, 2022

https://github.com/carbon-language/carbon-lang/tree/trunk/docs/design/lexical_conventions still says "TODO: operators"

@josh11b josh11b added the long term Issues expected to take over 90 days to resolve. label Dec 21, 2022
@Hech Hech mentioned this issue Jan 7, 2023
Closed
@aswin2108
Copy link
Contributor

Hey @Hech will you be continuing this or can I take over???

@josh11b If I can should I continue the work on the pr which is already made or just make a new one!?

@josh11b
Copy link
Contributor Author

josh11b commented Mar 1, 2023

Either is fine, but do please incorporate the feedback that was made on that PR, particularly the shift from "operator tokens" to "symbolic tokens".

@aswin2108 aswin2108 mentioned this issue Mar 5, 2023
Merged
josh11b pushed a commit that referenced this issue Jun 2, 2023
@aswin2108 @aviRon012
Added info on symbolic tokens in design docs (#2657)
6d399c8 
The [Operators proposal #601](#601) got accepted and but the details were not updated in the design docs. Added `symbolic_tokens.md` file to add the details of the proposal and its discussion.

Closes #1992 

Co-authored-by: Avi Aaron <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Possibly a good first issue for newcomers long term Issues expected to take over 90 days to resolve.
Projects
None yet
Milestone
No milestone
2 participants
@josh11b @aswin2108