Operator tokens #601
Merged
Operator tokens #601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
proposal rfc
jonmeow
reviewed
Jun 29, 2021
josh11b
reviewed
Jun 29, 2021
josh11b
approved these changes
Jun 30, 2021
chandlerc
reviewed
Jun 30, 2021
There was a problem hiding this comment.
I know there was a bunch of discussion in the #syntax Discord channel as well here, but a few orthogonal comments in the interim...
Also, to be clear, I quite like the high level direction. I think it is a nicely balanced set of trade-offs. Now we just need the details to be sorted out....
jonmeow
reviewed
Jun 30, 2021
Allow unspaced binary operators to be followed by `{` or `[` for
symmetry with allowing them to be preceded by `}` or `]` and in
anticipation of struct literals that begin with `{`.
|
Looks good, thank you. 👍 |
chandlerc
reviewed
Jul 2, 2021
chandlerc
approved these changes
Jul 3, 2021
|
(I also resolved a couple of comment threads that seemed fully addressed. The only remaining threads are mine and as stated, I'm happy with @zygoloid resoling them and landing.) |
github-actions
bot
added
proposal accepted
Co-authored-by: Chandler Carruth <[email protected]>
chandlerc
added a commit
that referenced
this pull request
Jun 28, 2022
Proposal: lexical rules for operator tokens. Co-authored-by: Chandler Carruth <[email protected]>
Merged
josh11b
pushed a commit
that referenced
this pull request
Jun 2, 2023
The [Operators proposal #601](#601) got accepted and but the details were not updated in the design docs. Added `symbolic_tokens.md` file to add the details of the proposal and its discussion. Closes #1992 Co-authored-by: Avi Aaron <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lexical rules for operator tokens.