-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CIP-0005 | Add governance vote key prefix #342
Conversation
- add 'gov_sk' as the prefix for a governacne_signing/secret_key - add 'gov_vk' as the prefix for a governacne_verification/public_key can be used f.e. with CIP-0036 to export vote(governance)-public-keys from wallets for delegation purpose in a format like: `gov_vk12a6cjyf98a4nrhe2slqsavy29jdcg5rk3jud6rfh3kfl0shzyrcqkwgdzk`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can see how this would be needed as long as @KtorZ agrees, and as long as gov_
as a prefix is neither too general nor too specific (@SebastienGllmt ?)
For example, the keys that will be derived from the path {
"type": "PaymentExtendedVerificationKeyShelley_ed25519_bip32",
"description": "Governance Verification Key",
"cborHex": "5840c2cd50d8a231fbc1444d65abab4f6bf74178e6de64722558eeef0b73de293a8a3e852c83508c7d300593734ec84351c3d1916d00571a57f3c0f63a7c972eb299"
} with "Governance Verification Key" or "Governance Hardware Verification Key" in the description (unclear until now if the type will be changed to |
Looks sensible to me! |
LGTM 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sensible change imo
can be used f.e. with CIP-0036 to export vote(governance)-public-keys from wallets for delegation purpose in a format like:
gov_vk12a6cjyf98a4nrhe2slqsavy29jdcg5rk3jud6rfh3kfl0shzyrcqkwgdzk