-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cardano): add support for CIP36 governance registration format #82
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good in general. I left just a few small suggestions.
As mentioned offline - I wasn't able to compare the auxiliary data hash with cardano-cli so please investigate. The produced data look good to me though.
@davidmisiak One thing I noticed while reviewing the connect PR. Maybe we could display "Voting purpose: Catalyst" and "Voting purpose: Other" for voting purpose 0 and other respectively. What do you think? |
What about |
I think the number should be displayed even in case there is some text. Esp. because "other" might expand in the future. If there is enough space on the screen, go for it (I won't do anything on Ledger, I guess it's not worth the additional code size --- you have to declare tmp buffers etc. to concatenate strings in C). |
564b49f
to
cd333a8
Compare
cd333a8
to
6994d3f
Compare
6994d3f
to
fe78d0c
Compare
fe78d0c
to
e57e42e
Compare
Merged in trezor#2561 |
This PR adds support for CIP36 governance registration format. Changes:
delegations
array (each delegation consists of a voting key and its voting power proportion) as an alternative to delegating the entire voting power to a single voting key. The array is embedded in the protobuf message due to simplicity (max. 32 delegations).voting_purpose
integer (currently 0 = Catalyst, 1 = other). For CIP36 registrations, this field is always serialized, (value 0 is used if not provided by the client).Catalyst
occurences are replaced bygovernance
, since the format should be usable for other governance purposes, not only Catalyst.ed25519_pk
bech32 prefix is replaced bygov_vk
for the purpose of displaying voting public keys.The new 1694' derivation path and the vote cast call implementation is not included in this PR.