Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CIP-0127? | Integration of ripemd_160 into Plutus #826

Merged
merged 14 commits into from
Oct 15, 2024

Conversation

paluh
Copy link
Contributor

@paluh paluh commented May 22, 2024

@rphair rphair added the Category: Plutus Proposals belonging to the 'Plutus' category. label May 22, 2024
@paluh paluh marked this pull request as ready for review May 22, 2024 15:49
Copy link
Collaborator

@rphair rphair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@paluh thanks for submitting this & we'll introduce it at our next CIP editor's meeting (https://hackmd.io/@cip-editors/89).

Since this is modelled on

as reported in af924ad#commitcomment-142326398... @michaelpj is this curve addition on the implementation schedule in a way similar to what you reported in #524 (comment)? (edit, p.s.: cc @zliu41)

CIP-????/README.md Outdated Show resolved Hide resolved
CIP-????/README.md Outdated Show resolved Hide resolved
CIP-????/README.md Outdated Show resolved Hide resolved
CIP-????/README.md Outdated Show resolved Hide resolved
CIP-????/README.md Outdated Show resolved Hide resolved
CIP-????/README.md Outdated Show resolved Hide resolved
CIP-????/README.md Outdated Show resolved Hide resolved
@rphair
Copy link
Collaborator

rphair commented May 28, 2024

@zliu41, following up on my earlier question in #826 (review) ... if I remember correctly from the just-finished CIP meeting, @paluh@perturbing says he was informed this is coming in the hard fork after Chang... can you verify?

paluh and others added 2 commits May 28, 2024 20:15
@paluh
Copy link
Contributor Author

paluh commented May 28, 2024

Minor comment from my side - @rphair I think that @perturbing suggested this timeline. I think that the exact timeline is not yet known but I hope that just by following the keccak256 path I can help streamline the process - I already started working on it.

Co-authored-by: Ryan <[email protected]>
Copy link
Collaborator

@Crypto2099 Crypto2099 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fairly straight forward and aligned with the direction of previous introduction of new signature or hashing methods to Plutus. We have at least introductory "team" acceptance of the goal although no clear timeline yet so I think this one should be relatively easy to slap a number on and advance through the stages towards merging and eventual acceptance.

CIP-????/README.md Outdated Show resolved Hide resolved
@paluh
Copy link
Contributor Author

paluh commented Jun 4, 2024

Quick update:

@rphair
Copy link
Collaborator

rphair commented Jun 4, 2024

Good news @paluh about #826 (comment). To help document that progress, I fixed the formatting of the Acceptance Criteria tickboxes... can you update & keep updated those box ticks (adding GitHub links, if you agree it's appropriate) with the inclusion of IntersectMBO/cardano-base#480 and the outcome of IntersectMBO/plutus#6147?

@paluh
Copy link
Contributor Author

paluh commented Jun 4, 2024

Hi @rphair, thanks a lot for the fixes. I will update the PR tomorrow if that is ok and keep you informed about the further progress as well.

@rphair rphair changed the title CIP-???? | Integration of ripemd_160 into Plutus CIP-0127? | Integration of ripemd_160 into Plutus Jul 14, 2024
Copy link
Collaborator

@rphair rphair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@paluh we are still looking forward to the evidence of support from Cardano projects as outlined above & hope the number assignment will help with these community & stakeholder discussions. In the meantime please rename the containing directory to CIP-0127 🎉

CIP-????/README.md Outdated Show resolved Hide resolved
@rphair
Copy link
Collaborator

rphair commented Aug 20, 2024

@paluh how would you describe what we are waiting for, as I tried to express in #826 (review)? Is it the Plutus team?

If so we are trying to find a way to tag such PRs appropriately — according to issue #883, with a GitHub label — that indicates we might be waiting for something out of the author's hands (such as Waiting for Project). For now I'll mark it Waiting for Author & if appropriate then I'll create a new tag & apply it here.

In any case please let us know how this stands with Plutus endorsement (cc @zliu41) if you have any further information about how this is progressing.

@rphair rphair added the State: Waiting for Author Proposal showing lack of documented progress by authors. label Aug 20, 2024
@rphair
Copy link
Collaborator

rphair commented Sep 24, 2024

@paluh with no response to #826 (review) after over 2 months, it looks like this CIP is no longer being pursued (not saying anything about the integration itself, which may well be proceeding independently). As I understand it, work by the Plutus implementors is driven by CIPs rather than pull requests: so this should either be finalised according to their satisfaction (cc @zliu41) or closed.

@rphair rphair added State: Likely Abandoned Close if confirmed abandoned (long waiting). and removed State: Waiting for Author Proposal showing lack of documented progress by authors. labels Sep 24, 2024
@perturbing
Copy link
Collaborator

@rphair, this cip is already implemented quite a bit, and is expected (and on track) to be added to plutus next hf (chang + 1).

It has been integrated into plutus here. With this done, we can check off the first four acceptance criteria :)

I believe there may have been a lack of communication due to the rapid pace at which this was implemented. I would like to express my gratitude to @paluh for his outstanding work and perseverance!

@rphair
Copy link
Collaborator

rphair commented Sep 24, 2024

Thanks @perturbing for the update on the context & @paluh for the great work in the background ⭐ ... should therefore be able to merge at next meeting or earlier so marking Last Check.

@rphair rphair added State: Last Check Review favourable with disputes resolved; staged for merging. and removed State: Likely Abandoned Close if confirmed abandoned (long waiting). labels Sep 24, 2024
@rphair rphair merged commit e4a2380 into cardano-foundation:master Oct 15, 2024
@rphair rphair removed the State: Last Check Review favourable with disputes resolved; staged for merging. label Oct 15, 2024
@paluh
Copy link
Contributor Author

paluh commented Oct 24, 2024

Hi, I'm really sorry for not being responsive. I'm heavily overloaded with daily work and Catalyst side projects... thanks a lot of merging this CIP! I hope to deliver really compelling examples of its usefulness in the context of Bitcoin bridging :-)

Can I add myself and @kwxm to the implementators section?

@rphair
Copy link
Collaborator

rphair commented Oct 25, 2024

Can I add myself and @kwxm to the implementators section?

yes @paluh that sounds reasonable to me based on your references. Can you open a PR that adds yourselves as implementors: containing a link back to #826 (comment) and/or the references above?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Plutus Proposals belonging to the 'Plutus' category.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants