-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CIP-0127? | Integration of ripemd_160
into Plutus
#826
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@paluh thanks for submitting this & we'll introduce it at our next CIP editor's meeting (https://hackmd.io/@cip-editors/89).
Since this is modelled on
as reported in af924ad#commitcomment-142326398... @michaelpj is this curve addition on the implementation schedule in a way similar to what you reported in #524 (comment)? (edit, p.s.: cc @zliu41)
Co-authored-by: Robert Phair <[email protected]>
Co-authored-by: Robert Phair <[email protected]>
@zliu41, following up on my earlier question in #826 (review) ... if I remember correctly from the just-finished CIP meeting, |
Co-authored-by: Ryan <[email protected]>
Co-authored-by: Ryan <[email protected]>
Minor comment from my side - @rphair I think that @perturbing suggested this timeline. I think that the exact timeline is not yet known but I hope that just by following the |
Co-authored-by: Ryan <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fairly straight forward and aligned with the direction of previous introduction of new signature or hashing methods to Plutus. We have at least introductory "team" acceptance of the goal although no clear timeline yet so I think this one should be relatively easy to slap a number on and advance through the stages towards merging and eventual acceptance.
Co-authored-by: Adam Dean <[email protected]>
Quick update:
|
Good news @paluh about #826 (comment). To help document that progress, I fixed the formatting of the Acceptance Criteria tickboxes... can you update & keep updated those box ticks (adding GitHub links, if you agree it's appropriate) with the inclusion of IntersectMBO/cardano-base#480 and the outcome of IntersectMBO/plutus#6147? |
Hi @rphair, thanks a lot for the fixes. I will update the PR tomorrow if that is ok and keep you informed about the further progress as well. |
ripemd_160
into Plutusripemd_160
into Plutus
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@paluh we are still looking forward to the evidence of support from Cardano projects as outlined above & hope the number assignment will help with these community & stakeholder discussions. In the meantime please rename the containing directory to CIP-0127
🎉
@paluh how would you describe what we are waiting for, as I tried to express in #826 (review)? Is it the Plutus team? If so we are trying to find a way to tag such PRs appropriately — according to issue #883, with a GitHub label — that indicates we might be waiting for something out of the author's hands (such as In any case please let us know how this stands with Plutus endorsement (cc @zliu41) if you have any further information about how this is progressing. |
@paluh with no response to #826 (review) after over 2 months, it looks like this CIP is no longer being pursued (not saying anything about the integration itself, which may well be proceeding independently). As I understand it, work by the Plutus implementors is driven by CIPs rather than pull requests: so this should either be finalised according to their satisfaction (cc @zliu41) or closed. |
@rphair, this cip is already implemented quite a bit, and is expected (and on track) to be added to plutus next hf (chang + 1). It has been integrated into plutus here. With this done, we can check off the first four acceptance criteria :) I believe there may have been a lack of communication due to the rapid pace at which this was implemented. I would like to express my gratitude to @paluh for his outstanding work and perseverance! |
Co-authored-by: Robert Phair <[email protected]>
Thanks @perturbing for the update on the context & @paluh for the great work in the background ⭐ ... should therefore be able to merge at next meeting or earlier so marking |
Hi, I'm really sorry for not being responsive. I'm heavily overloaded with daily work and Catalyst side projects... thanks a lot of merging this CIP! I hope to deliver really compelling examples of its usefulness in the context of Bitcoin bridging :-) Can I add myself and @kwxm to the implementators section?
|
yes @paluh that sounds reasonable to me based on your references. Can you open a PR that adds yourselves as implementors: containing a link back to #826 (comment) and/or the references above? |
(rendered latest version of proposal)