Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement API types for delegation endpoints #895

Closed
KtorZ opened this issue Oct 23, 2019 · 1 comment
Closed

Implement API types for delegation endpoints #895

KtorZ opened this issue Oct 23, 2019 · 1 comment
Assignees
@paweljakubas
Milestone
Create Delegation...

Comments

@KtorZ
Copy link
Member

KtorZ commented Oct 23, 2019 •
edited by paweljakubas
Loading

Context

Decision

  • Create API types definitions needed to implement these endpoints
  • Wire up the endpoint declarations into the Servant server
  • Implement handlers as throwError err501

Acceptance Criteria

  1. The server must serve the API endpoint corresponding to the joinStakePool operation from the swagger spec
  2. The server must serve the API endpoint corresponding to the quitStakePool operation from the swagger spec
  3. Endpoints handlers should not be implemented yet and return a 501 Not Implemented HTTP error when accessed.

Development Plan

PR

Number Base
#920 master

QA

Two endpoints were added. It is worth if they are present and behave as REST verbs suggest. Moreover, if handled errors as advertised in swagger are as expected
@KtorZ KtorZ added this to the Create Delegation Certificate milestone Oct 23, 2019
@jonathanknowles jonathanknowles changed the title Implement delegation endpoints API types Implement API types for delegation endpoints Oct 24, 2019
@KtorZ KtorZ removed the UNCONFIRMED label Oct 24, 2019
@paweljakubas paweljakubas self-assigned this Oct 25, 2019
@paweljakubas paweljakubas mentioned this issue Oct 25, 2019
Merged
2 tasks
iohk-bors bot added a commit that referenced this issue Oct 29, 2019
@iohk-bors @paweljakubas @jonathanknowles
Merge #920
8812cd2 
920: Api types for delegation endpoints r=jonathanknowles a=paweljakubas

# Issue Number

<!-- Put here a reference to the issue this PR relates to and which requirements it tackles -->
#895 

# Overview

<!-- Detail in a few bullet points the work accomplished in this PR -->

- [x] I have added types for stake delegation
- [x] I have reused ApiMigrateByronWalletData within byron and pool stuff endpoints and rename it to ApiWalletPassphrase


# Comments

<!-- Additional comments or screenshots to attach if any -->

<!-- 
Don't forget to:

 ✓ Self-review your changes to make sure nothing unexpected slipped through
 ✓ Assign yourself to the PR
 ✓ Assign one or several reviewer(s)
 ✓ Once created, link this PR to its corresponding ticket
 ✓ Acknowledge any changes required to the Wiki
-->


Co-authored-by: Pawel Jakubas <[email protected]>
Co-authored-by: Jonathan Knowles <[email protected]>
@piotr-iohk piotr-iohk mentioned this issue Nov 5, 2019
Merged
1 task
@piotr-iohk
Copy link
Contributor

Added some preliminary tests in #962.

iohk-bors bot added a commit that referenced this issue Nov 7, 2019
@iohk-bors
Merge #962
3797c0a 
962: Stake pools join quit stub tests r=piotr-iohk a=piotr-iohk

# Issue Number

#895

# Overview

<!-- Detail in a few bullet points the work accomplished in this PR -->

- [ ] Added some preliminary tests for join/quit stake pool endpoints...


# Comments

<!-- Additional comments or screenshots to attach if any -->

<!-- 
Don't forget to:

 ✓ Self-review your changes to make sure nothing unexpected slipped through
 ✓ Assign yourself to the PR
 ✓ Assign one or several reviewer(s)
 ✓ Once created, link this PR to its corresponding ticket
 ✓ Acknowledge any changes required to the Wiki
-->


Co-authored-by: Piotr Stachyra <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@paweljakubas paweljakubas

Labels
None yet
Projects
None yet
Milestone
Create Delegation Certificate
Development

No branches or pull requests
3 participants
@KtorZ @paweljakubas @piotr-iohk