Stake pools join quit stub tests

[piotr-iohk]

Issue Number

#895

Overview

• Added some preliminary tests for join/quit stake pool endpoints...

Comments

[piotr-iohk]

Addressed review comments and added few more cases.

[jonathanknowles]

Looks good to me! I've made a comment regarding a formatting suggestion.

[jonathanknowles]

This line is only slightly over the line length limit, but I hope you can forgive me for using it to illustrate a point. 😄

Of course we want to make the description long enough that the test is self-documenting. However, the line length limit seemingly imposes a constraint on the description length.

Though perhaps there's a way to avoid the above issue. How about using a format similar to the following:

    it "STAKE_POOLS_JOIN_01: \
        \I definitely can quit and join another."
        $ \ctx -> do
            (_, p1:p2:_) <- eventually $
                unsafeRequest @[ApiStakePool] ctx listStakePoolsEp Empty
            w <- emptyWallet ctx
            ...

This format has the advantage of scaling nicely even when the description gets longer:

    it "LAUNCH_MISSILES_01: \
        \When initiating a missile attack, rockets are fired in such a way \
        \as to prevent excessive collateral damage to neighbouring friendly \
        \countries."
        $ \ctx -> do
            (_, p1:p2:_) <- eventually $
                unsafeRequest @[ApiStakePool] ctx listStakePoolsEp Empty
            w <- emptyWallet ctx
            ...

@piotr-iohk What do you think?

[piotr-iohk]

@jonathanknowles agreed and fixed. :)

[paweljakubas]

LGTM! There is going to be more tests checking pool id is present, valid in #970

[piotr-iohk]

bors r+

[iohk-bors]

Build succeeded

• buildkite/cardano-wallet