Generalize UTxO identifier type within UTxOSelection.
#3155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base automatically changed from
jonathanknowles/coin-selection-compound-input-id
to
master
February 24, 2022 08:31
We eventually intend to use `u` as a type parameter that represents unique UTxO identifiers. So using `s` as a type parameter to represent a type of selection makes sense here.
The `UTxOSelection` module already uses the term "UTxO" to refer to a single UTxO (single unspent transaction output). We no longer depend on the wallet's `UTxO` type here, and since these functions both return values of type `Map`, we can avoid ambiguity by using the term `Map` in the names of these functions.
We use the following convention for identifier names:
- `s` represents a selection of type `UTxOSelection`.
- `u` represents a unique identifier for an individual UTxO (unspent
transaction output).
- `b` represents a `TokenBundle` value.
- `i` represents an index of type `UTxOIndex`.
jonathanknowles
force-pushed
the
jonathanknowles/use-type-parameter-for-utxo-identifier-in-utxo-selection
branch
from
9f390c0
to
d75a860
Compare
Anviking
approved these changes
Feb 24, 2022
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Feb 24, 2022
3155: Generalize UTxO identifier type within `UTxOSelection`. r=jonathanknowles a=jonathanknowles ## Issue Number ADP-1450 ## Background Within coin selection modules, we are steadily replacing all uses of `TxIn`, `Address`, `TxOut` with type parameters, so that the coin selection library does not depend on these concrete wallet types. ## Summary This PR replaces all uses of `InputId` (a temporary type synonym introduced in #3149) with a type parameter within module `UTxOSelection`. We use the following convention for type parameters and identifier names: - `u` represents a unique identifier for an individual UTxO (unspent transaction output). - `s` represents a selection of type `UTxOSelection`. - `b` represents a `TokenBundle` value. - `i` represents an index of type `UTxOIndex`. Co-authored-by: Jonathan Knowles <[email protected]>
|
Build failed: Looks like the "Check Cabal Configure" stage failed: |
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Feb 24, 2022
3155: Generalize UTxO identifier type within `UTxOSelection`. r=Anviking a=jonathanknowles ## Issue Number ADP-1450 ## Background Within coin selection modules, we are steadily replacing all uses of `TxIn`, `Address`, `TxOut` with type parameters, so that the coin selection library does not depend on these concrete wallet types. ## Summary This PR replaces all uses of `InputId` (a temporary type synonym introduced in #3149) with a type parameter within module `UTxOSelection`. We use the following convention for type parameters and identifier names: - `u` represents a unique identifier for an individual UTxO (unspent transaction output). - `s` represents a selection of type `UTxOSelection`. - `b` represents a `TokenBundle` value. - `i` represents an index of type `UTxOIndex`. Co-authored-by: Jonathan Knowles <[email protected]>
|
Build failed: Another "Check Cabal Configure" failure: |
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Feb 24, 2022
3155: Generalize UTxO identifier type within `UTxOSelection`. r=jonathanknowles a=jonathanknowles ## Issue Number ADP-1450 ## Background Within coin selection modules, we are steadily replacing all uses of `TxIn`, `Address`, `TxOut` with type parameters, so that the coin selection library does not depend on these concrete wallet types. ## Summary This PR replaces all uses of `InputId` (a temporary type synonym introduced in #3149) with a type parameter within module `UTxOSelection`. We use the following convention for type parameters and identifier names: - `u` represents a unique identifier for an individual UTxO (unspent transaction output). - `s` represents a selection of type `UTxOSelection`. - `b` represents a `TokenBundle` value. - `i` represents an index of type `UTxOIndex`. Co-authored-by: Jonathan Knowles <[email protected]>
|
Build failed: So the "Check Cabal Configure" stage failed, but it succeeds if it's run a second time. |
|
bors r+ |
|
Build succeeded: |
iohk-bors
bot
deleted the
jonathanknowles/use-type-parameter-for-utxo-identifier-in-utxo-selection
branch
WilliamKingNoel-Bot
pushed a commit
that referenced
this pull request
Feb 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
ADP-1450
Background
Within coin selection modules, we are steadily replacing all uses of
TxIn,Address,TxOutwith type parameters, so that the coin selection library does not depend on these concrete wallet types.Summary
This PR replaces all uses of
InputId(a temporary type synonym introduced in #3149) with a type parameter within moduleUTxOSelection.We use the following convention for type parameters and identifier names:
urepresents a unique identifier for an individual UTxO (unspent transaction output).srepresents a selection of typeUTxOSelection.brepresents aTokenBundlevalue.irepresents an index of typeUTxOIndex.