Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generalize UTxO identifier type within UTxOSelection. #3155

Merged
merged 4 commits into from
Feb 25, 2022
Merged

Generalize UTxO identifier type within UTxOSelection. #3155

merged 4 commits into from
Feb 25, 2022

Commits on Feb 24, 2022

  1. Rename type parameter u to s in type UTxOSelection. 

    We eventually intend to use `u` as a type parameter that represents
unique UTxO identifiers.

So using `s` as a type parameter to represent a type of selection makes
sense here.
    @jonathanknowles
    jonathanknowles committed Feb 24, 2022
    Configuration menu
    Copy the full SHA
    61f2f2a View commit details
    Browse the repository at this point in the history

  2. Parameterize UTxO unique identifier type in UTxOSelection.

    @jonathanknowles
    jonathanknowles committed Feb 24, 2022
    Configuration menu
    Copy the full SHA
    e710b84 View commit details
    Browse the repository at this point in the history

  3. Rename {leftover,selected}UTxO to {leftover,selected}Map. 

    The `UTxOSelection` module already uses the term "UTxO" to refer to a
single UTxO (single unspent transaction output).

We no longer depend on the wallet's `UTxO` type here, and since these
functions both return values of type `Map`, we can avoid ambiguity by
using the term `Map` in the names of these functions.
    @jonathanknowles
    jonathanknowles committed Feb 24, 2022
    Configuration menu
    Copy the full SHA
    269e3da View commit details
    Browse the repository at this point in the history

  4. Revise identifier names within module UTxOSelection. 

    We use the following convention for identifier names:

  - `s` represents a selection of type `UTxOSelection`.
  - `u` represents a unique identifier for an individual UTxO (unspent
        transaction output).
  - `b` represents a `TokenBundle` value.
  - `i` represents an index of type `UTxOIndex`.
    @jonathanknowles
    jonathanknowles committed Feb 24, 2022
    Configuration menu
    Copy the full SHA
    d75a860 View commit details
    Browse the repository at this point in the history