Remove AoE from buckshot and flechette ammo until it's fixed #2792
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Balance "Remove AoE cone effects for buckshot and flechette ammo for now"
Purpose of change
Discovered while testing, shotgun AoE cones are in a bad state right now and not suitable for use with standard ammo in its current form. Its flaws aren't severe enough to be a problem with birdshot (which no sane person is going to use on NPCs anyway since even if it was function the base damage is too low to be worth it), but for buckshot it's a big problem.
Relevant bugs are:
Describe the solution
Reverted use of AoE cone for all buckshot ammo, giving it its old stats. I left the abstract inheritance from #2619 in for now instead of just reverting the PR wholesale, because it'll be useful to us to have those abstracts so it's less work to re-implement this when it's fixed.
I kept the nerf to flintlock flechette ammo since it having 60 range (having inherited from the base ammo with no range override) seems like a mistake, but I did not keep the massive boost to paper shot's range since that seems to be a copypaste issue. Then again, it seems AoE ammo ALSO doesn't gain anything from range bonuses on the gun (a third bug for me to report it seems) so it having double the range of regular paper ammo may have been partially intentional, since that would equal the range of paper cartridge through a flintlock musket.
Describe alternatives you've considered
Testing
Additional context
Relevant PR, this partially reverts changes from: #2619