iNML port #27

marcelwa · 2022-01-14T11:56:43Z

Port of the legacy iNML technology implementation, its gate library, and file writer to fiction's new data structures.

…ber types

…ember type declarations

…agnets according to MagCAD

…NORMAL (which might not exist in every technology)

codecov · 2022-01-17T12:20:15Z

Codecov Report

Merging #27 (d421842) into v0.4.0 (ad05ef1) will decrease coverage by 0.64%.
The diff coverage is 85.63%.

@@            Coverage Diff             @@
##           v0.4.0      #27      +/-   ##
==========================================
- Coverage   92.98%   92.34%   -0.65%     
==========================================
  Files          40       44       +4     
  Lines        4346     4714     +368     
==========================================
+ Hits         4041     4353     +312     
- Misses        305      361      +56

Impacted Files	Coverage Δ
include/fiction/io/dot_drawers.hpp	`93.06% <ø> (ø)`
include/fiction/technology/cell_technologies.hpp	`100.00% <ø> (ø)`
include/fiction/technology/qca_one_library.hpp	`87.93% <ø> (ø)`
include/fiction/io/write_qll_layout.hpp	`79.59% <79.59%> (ø)`
...ude/fiction/technology/inml_topolinano_library.hpp	`82.88% <82.88%> (ø)`
.../algorithms/physical_design/apply_gate_library.hpp	`100.00% <100.00%> (ø)`
include/fiction/layouts/bounding_box.hpp	`100.00% <100.00%> (ø)`
include/fiction/layouts/cell_level_layout.hpp	`100.00% <100.00%> (ø)`
include/fiction/layouts/gate_level_layout.hpp	`100.00% <100.00%> (ø)`
include/fiction/layouts/hexagonal_layout.hpp	`98.46% <100.00%> (ø)`
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad05ef1...d421842. Read the comment docs.

…dent

…pplying them

Bumps [libs/Catch2](https://github.com/catchorg/Catch2) from `6783411` to `1f881ab`. - [Release notes](https://github.com/catchorg/Catch2/releases) - [Commits](catchorg/Catch2@6783411...1f881ab) --- updated-dependencies: - dependency-name: libs/Catch2 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* ⬆️ Bump libs/Catch2 from `6783411` to `1f881ab` (#27) Bumps [libs/Catch2](https://github.com/catchorg/Catch2) from `6783411` to `1f881ab`. - [Release notes](https://github.com/catchorg/Catch2/releases) - [Commits](catchorg/Catch2@6783411...1f881ab) --- updated-dependencies: - dependency-name: libs/Catch2 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * ⬆️ Bump libs/parallel-hashmap from `7883cb6` to `d2bed96` (#33) Bumps [libs/parallel-hashmap](https://github.com/greg7mdp/parallel-hashmap) from `7883cb6` to `d2bed96`. - [Release notes](https://github.com/greg7mdp/parallel-hashmap/releases) - [Commits](greg7mdp/parallel-hashmap@7883cb6...d2bed96) --- updated-dependencies: - dependency-name: libs/parallel-hashmap dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * 🎨 return value of ``sidb_nm_position`` changed from meter to nanometer for consistency. * 🎨 renaming. --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Drewniok <[email protected]>

* ✨ header for temperature simulation * ✨ header for temperature simulation * ✅ occupation function with tests * 🚧 "critical temperature function" is implemented. Test also added. * 🚧 CT of "bestagon gates" can be simulated correctly * ✅ tests updated * ✅ tests updated * ✅ tests updated * 🎨 map replaced by vector * 📝 docu for new functions * 📝 docu for new functions * 🎨 ClangFormat changes Signed-off-by: ClangFormat <[email protected]> * 🚀 * ⬆️ submodules upgraded * 🎨 ClangFormat changes Signed-off-by: ClangFormat <[email protected]> * 🎨 small cahnges * 🎨 ClangFormat changes Signed-off-by: ClangFormat <[email protected]> * 🎨 replaced std::rand(), caused problem at temperature implementation * 🎨 small changes here and there * 🎨 reformat code * 🎨 ClangFormat changes Signed-off-by: ClangFormat <[email protected]> * 🎨 renaming function * ✨ flag added to decide between gate and random layout * ✨ flag added to decide between gate and random layout * ✨ flag added to decide between gate and random layout * ✨ min_energy added in occupation_probability.hpp * 🎨 Reformatted and cleaned up code * 🎨 ClangFormat changes Signed-off-by: ClangFormat <[email protected]> * 🎨 Slight revision for consistency * 🎨 renaming * ⬆️ Bump libs/Catch2 from `50bf00e` to `9a2a4ea` (#182) * 🎨 reformat code * redefinition of sidb_nm_position (#186) * ⬆️ Bump libs/Catch2 from `6783411` to `1f881ab` (#27) Bumps [libs/Catch2](https://github.com/catchorg/Catch2) from `6783411` to `1f881ab`. - [Release notes](https://github.com/catchorg/Catch2/releases) - [Commits](catchorg/Catch2@6783411...1f881ab) --- updated-dependencies: - dependency-name: libs/Catch2 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * ⬆️ Bump libs/parallel-hashmap from `7883cb6` to `d2bed96` (#33) Bumps [libs/parallel-hashmap](https://github.com/greg7mdp/parallel-hashmap) from `7883cb6` to `d2bed96`. - [Release notes](https://github.com/greg7mdp/parallel-hashmap/releases) - [Commits](greg7mdp/parallel-hashmap@7883cb6...d2bed96) --- updated-dependencies: - dependency-name: libs/parallel-hashmap dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * 🎨 return value of ``sidb_nm_position`` changed from meter to nanometer for consistency. * 🎨 renaming. --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Drewniok <[email protected]> * 👷 Use the GitHub token of the checked-out repo instead of the own for the `add-and-commit` action after clang-format has been run * 🎨 Changed the unit of the lambda-tf physical parameter from meter to nanometer (#188) * 🎨 Unit of `lambda_tf` is changed from meter to nanometer. * 🎨 `epsilon_r` is unit-less. * ✨ Added a function to round a number to `n` decimal places (#189) * ✨ small function to round numbers to ``n`` decimal places. * ✅ test added. * 🎨 implemented Marcel's suggestions. * 🎨 make use of new function in ``energy_distribution``. * ✨ Added an SiDB simulation file writer (#176) * ✨ Added a new unified return type for SiDB simulation * ✨ Added a file writer for SQD simulation runs parsable by SiQAD * 📝 Added and fixed docstrings * 📝 Added RST documentation * 📝 Removed superfluous newlines * 🎨 Incorporated clang-tidy's recommendations * 🎨 Rewrote `any_to_string` to be more performant and extensible * 🐛 Replaced the usage of the custom charge to string function with the one provided by `sidb_charge_state.hpp` * ✅ Added a test case for positive SiDBs * ✅ Added test cases for `any_to_string` * 🎨 ClangFormat changes Signed-off-by: ClangFormat <[email protected]> * 🐛 Added `inline` to `any_to_string` in order to avoid ODR problems * ✅ Fixed the test case * 🎨 ClangFormat changes Signed-off-by: ClangFormat <[email protected]> * 👽 Convert nm to Angstrom * 👽 Round distances and energy values to 6 decimal points * ✅ Added additional tests to cover more lines * 🎨 ClangFormat changes Signed-off-by: ClangFormat <[email protected]> --------- Signed-off-by: ClangFormat <[email protected]> Co-authored-by: ClangFormat <[email protected]> * 🎨 larger architectural changes. * 🎨 reformat code and documentation. * 🎨 small changes in exhaustive_ground_state_simulation.hpp due to unit changes from ``main`` branch. * 📝 added docu. * ⬆️ Bump ZedThree/clang-tidy-review from 0.12.2 to 0.13.0 (#193) * ⬆️ Bump libs/Catch2 from `9a2a4ea` to `10596b2` (#191) Bumps [libs/Catch2](https://github.com/catchorg/Catch2) from `9a2a4ea` to `10596b2`. - [Release notes](https://github.com/catchorg/Catch2/releases) - [Commits](catchorg/Catch2@9a2a4ea...10596b2) --- updated-dependencies: - dependency-name: libs/Catch2 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * ⬆️ Bump libs/parallel-hashmap from `d2bed96` to `7807157` (#192) Bumps [libs/parallel-hashmap](https://github.com/greg7mdp/parallel-hashmap) from `d2bed96` to `7807157`. - [Release notes](https://github.com/greg7mdp/parallel-hashmap/releases) - [Commits](greg7mdp/parallel-hashmap@d2bed96...7807157) --- updated-dependencies: - dependency-name: libs/parallel-hashmap dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * ✅ Ensured a reproducible SiDB order for test reproducibility (#194) * ✅ Ensured a reproducible SiDB order for test reproducibility * 💚 Ordered surfaces as well --------- Co-authored-by: Jan Drewniok <[email protected]> * 🎨 ClangFormat changes Signed-off-by: ClangFormat <[email protected]> * ⬆️ Bump DoozyX/clang-format-lint-action from 0.15 to 0.16 (#196) Bumps [DoozyX/clang-format-lint-action](https://github.com/DoozyX/clang-format-lint-action) from 0.15 to 0.16. - [Release notes](https://github.com/DoozyX/clang-format-lint-action/releases) - [Commits](DoozyX/clang-format-lint-action@v0.15...v0.16) --- updated-dependencies: - dependency-name: DoozyX/clang-format-lint-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * 🎨 changes after review. * 🎨 ClangFormat changes Signed-off-by: ClangFormat <[email protected]> * 🎨 changes after review. * 🎨 use data type for energy distribution. * 🎨 additional ``else`` to try to fix windows build issue. * ✨ Make ClangFormat aware of different line ending types and enforce `LF` (#177) * 🎨 Added a flag to the ClangFormat config to enforce LF line endings (as of version 16) * 🎨 Re-applied ClangFormat to the project * ⬆️ Switched to ClangFormat 16 * 📝 add links for RST. * 📝 add links for RST. * 📝 add named anchor. * 📝 use ``-`` instead of ``_``. * 🐛 add missing ``$`` in docstring. * 🎨 ClangFormat changes Signed-off-by: ClangFormat <[email protected]> * 🎨 copy enum class to try to solve window build issue. * 🎨 tiny change in docu. * 🎨 ClangFormat changes Signed-off-by: ClangFormat <[email protected]> * 🎨 ClangFormat changes Signed-off-by: ClangFormat <[email protected]> * 🔥 remove file from git. * ✅ add additional test. * 🐛 add ``recompute_energy`` and test which failed before. * 🎨 change to scoped enumerator. * 🎨 ClangFormat changes Signed-off-by: ClangFormat <[email protected]> * 🎨 use enum struct. * 🔥 remove ``enum class``due to windows CI issue. * 🎨 ClangFormat changes Signed-off-by: ClangFormat <[email protected]> * 🎨 replace reference. * ✨ code to generate unique random layouts. * ✨ Temperature-aware simulation can be conducted with ``exgs`` or ``quicksim``. All simulation engines use ``sidb_simulation_result`` now to collect results. * 🎨 ClangFormat changes Signed-off-by: ClangFormat <[email protected]> * 🎨 rename struct member. * 🎨 activate automatic state count detection. * ⬆️ Bump libs/parallel-hashmap from `7807157` to `9f09034` (#199) * 🎨 Ensured SiQAD compatibility of SiDB simulation result writer (#197) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * 🎨 fix ``state count`` to three. Two is not supported by SiQAD yet. * 🎨 reformat code. --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Marcel Walter <[email protected]> * 🎨 update after review (main change: replace stats_pointer as input for simulators). * 🎨 ClangFormat changes Signed-off-by: ClangFormat <[email protected]> * 🎨 introduce impl_class for quickexact. * 🎨 remove ``const``keyword. * 🎨 add ``const``keyword. * 🎨 split in several smaller functions. * 🎨 rename some functions. * 📝 add docu. * ✨ automatic base number detection can be turned ``on`` and ``off``. * 📝 add more documentation. * 🔥 remove files to shift it to separate PR. * 🎨 change order of ``const``keyword and type. * 📝 add RST. * 📝 add documentation. * 💚 add ``const`` keyword. * 🎨 smaller changes to try to fix test issue. * ✅ small change to avoid windows issue. * 📝 add documentation. --------- Signed-off-by: ClangFormat <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Drewniok <[email protected]> Co-authored-by: ClangFormat <[email protected]> Co-authored-by: Marcel Walter <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

marcelwa added 17 commits January 11, 2022 19:54

feat: added shifted_cartesian_layout data type

45411ea

fix: added 'typename' declaration as demanded by clang

bb36bee

fix: removed 'typename' declaration for functions but kept it for mem…

97d768f

…ber types

fix: Visual Studio Compiler doesn't seem to like the idea of hiding m…

eee82c6

…ember type declarations

feat: added a DOT drawer for shifted Cartesian layouts

c22cd84

feat: Ported the iNML ToPoliNano library

ac08e92

docs: Added documentation for the iNML ToPoliNano library

10d4ea8

docs: small consistency fix in library headers

478eb35

feat: Added function magcad_magnet_count to determine the number of m…

36494bf

…agnets according to MagCAD

feat: Ported bounding box calculation

c35249e

feat: Added bounding box size operations and tests

896b373

feat: Ported QCC file writer for ToPoliNano & MagCAD component files

c107bc5

fix: Name lookup for write_qcc_layout in RST documentation

07df19d

restruct: Added statics and missing includes

c331310

fix: Fixed get_cell_mode to return the default cell mode rather than …

0069cc0

…NORMAL (which might not exist in every technology)

feat: Ported the function to straighten iNML ToPoliNano wires

f5f036d

Removed the legacy code folder as all code has been ported

d6a705a

marcelwa added 10 commits January 17, 2022 14:24

Added 'const' and fixed some docstrings

7bf5285

feat: Added a QLL file writer for ToPoliNano and MagCAD layout files

776fbbd

docs: Added RST documentation for write_qll_layout

6cf8480

test: Added test cases for write_qcc_layout and write_qll_layout

5bd2396

Removed QCC test because the hashing function is not platform-indepen…

c761a0b

…dent

test: Added ToPoliNano library tests and fixed a bug that was found a…

4c3585b

…pplying them

docs: Reworded acknowledgments

e5a4eb9

docs: Added missing SiDB tech and bounding box cost metric to README

5c71613

fix: Changed singular to plural formulations

352cb3f

Addressed TODOs in the ToPoliNano library

d421842

marcelwa merged commit c68af03 into v0.4.0 Jan 17, 2022

marcelwa deleted the inml_port branch January 17, 2022 19:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

iNML port #27

iNML port #27

marcelwa commented Jan 14, 2022

codecov bot commented Jan 17, 2022 •

edited

Loading

iNML port #27

iNML port #27

Conversation

marcelwa commented Jan 14, 2022

codecov bot commented Jan 17, 2022 • edited Loading

Codecov Report

codecov bot commented Jan 17, 2022 •

edited

Loading