✨ Support defects in the SiDB Gate Designer #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drewniok
changed the title
SiDB Gate Designer
|
clang-tidy review says "All clean, LGTM! 👍" |
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #289 +/- ##
==========================================
+ Coverage 95.82% 95.85% +0.02%
==========================================
Files 98 98
Lines 9544 9550 +6
==========================================
+ Hits 9146 9154 +8
+ Misses 398 396 -2
☔ View full report in Codecov by Sentry. |
marcelwa
requested changes
Sep 21, 2023
include/fiction/algorithms/physical_design/design_sidb_gates.hpp
Outdated
Show resolved
Hide resolved
include/fiction/algorithms/simulation/sidb/random_sidb_layout_generator.hpp
Outdated
Show resolved
Hide resolved
include/fiction/algorithms/simulation/sidb/random_sidb_layout_generator.hpp
Outdated
Show resolved
Hide resolved
test/algorithms/simulation/sidb/random_sidb_layout_generator.cpp
Outdated
Show resolved
Hide resolved
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
test/algorithms/simulation/sidb/random_sidb_layout_generator.cpp
Dismissed
Show dismissed
Hide dismissed
|
clang-tidy review says "All clean, LGTM! 👍" |
|
We still need to get the Windows CI up and running again, but besides that, this PR looks good to me. |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
clang-tidy review says "All clean, LGTM! 👍" |
marcelwa
approved these changes
Sep 26, 2023
marcelwa
changed the title
SiDB Gate Designer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR extends the SiDB Gate Designer to support defects.
Checklist: