Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dequeueProposalsIfReady() should be at the bottom of methods #10091

Closed
martinvol opened this issue Jan 3, 2023 · 1 comment · Fixed by #10268 or #10324
Closed

dequeueProposalsIfReady() should be at the bottom of methods #10091

martinvol opened this issue Jan 3, 2023 · 1 comment · Fixed by #10268 or #10324
Assignees
Labels

Comments

@martinvol
Copy link
Contributor

martinvol commented Jan 3, 2023

Expected Behavior

Some methods, like upvote, should be able to be called with the same id they have at the time of executing.

Current Behavior

Some methods in Governance, like upvote, try to do dequeueProposalsIfReady at the beginning, changing the ID of the proposals in-fly and making them difficult to calculate. It causes this issue on the cli: #10064

This issue is related to: #9737

Copy link
Contributor

github-actions bot commented May 3, 2024

This issue is stale and will be closed in 30 days without activity

@github-actions github-actions bot added the stale label May 3, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jun 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants