Fix dequeueProposalIfReady() for expired proposals. #10324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pahor167
approved these changes
May 22, 2023
|
Can you update the title of this PR? |
montera82
changed the title
montera82
force-pushed
the
montera82/10091-fix
branch
from
c16c0ed
to
3fcb165
Compare
|
woo |
Closed
pahor167
added a commit
that referenced
this pull request
Aug 4, 2023
* Revert "Fix dequeueProposalIfReady() for expired proposals. (#10324)" This reverts commit 890d195. * Revert "Update upvode function (#10268)" This reverts commit ce75f49. * ReleaseGold refund test fix (#10440) * ReleaseGold refund test fix * gas fix * Pahor/cli fix2 (#10457) * ReleaseGold refund test fix * gas fix * PR comments * removal of comment * Cli fix 2 * Running GitHub Action workflow from release/* branches * Fix regex * Trigger protocol tests on release branches * add logging * lint fix * uniswap test fix * Trigger Identity tests too --------- Co-authored-by: Javier Cortejoso <[email protected]>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Because this introduces a tiny bug which allows expired PRoposals to enter into the dequeued list. Those just need to be deleted w/o entering the list!
Thanks to @pahor167 for extra pointing this out.
Reverts #10268
Tested
Unit test.
Related issues
Documentation
no need