Update upvode function #10268
Merged
Update upvode function #10268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
montera82
commented
Apr 21, 2023
pahor167
reviewed
Apr 21, 2023
pahor167
reviewed
May 17, 2023
pahor167
reviewed
May 17, 2023
montera82
force-pushed
the
montera82/10091
branch
from
c674707
to
578e97b
Compare
montera82
added a commit
that referenced
this pull request
May 19, 2023
This reverts commit ce75f49.
This was referenced May 19, 2023
Closed
pahor167
added a commit
that referenced
this pull request
Aug 4, 2023
* Revert "Fix dequeueProposalIfReady() for expired proposals. (#10324)" This reverts commit 890d195. * Revert "Update upvode function (#10268)" This reverts commit ce75f49. * ReleaseGold refund test fix (#10440) * ReleaseGold refund test fix * gas fix * Pahor/cli fix2 (#10457) * ReleaseGold refund test fix * gas fix * PR comments * removal of comment * Cli fix 2 * Running GitHub Action workflow from release/* branches * Fix regex * Trigger protocol tests on release branches * add logging * lint fix * uniswap test fix * Trigger Identity tests too --------- Co-authored-by: Javier Cortejoso <[email protected]>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added check to ensure upvote function does not proceed if proposalID is not even in the queue.
Tested
Scenario already covered by tests.
Related issues
Documentation
no need