Skip to content
This repository has been archived by the owner on Jul 31, 2023. It is now read-only.

Rename plugin/ocgrpc/testdata #549

Closed
zombiezen opened this issue Mar 9, 2018 · 0 comments
Closed

Rename plugin/ocgrpc/testdata #549

zombiezen opened this issue Mar 9, 2018 · 0 comments
Assignees

Comments

@zombiezen
Copy link

As per https://golang.org/cmd/go/#hdr-Test_packages, the go tool will ignore directories called "testdata" when evaluating packages to build. However, this actually holds a build-able go package that trace_common_test.go depends on. This causes various issues in tools that try to do import graph analysis, so please consider renaming the package (perhaps internal/testpb?).

/cc @rakyll

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants