This repository has been archived by the owner on Jul 31, 2023. It is now read-only.
Rename plugin/ocgrpc/testdata to plugin/internal/testpb #554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rakyll
reviewed
Mar 12, 2018
plugin/ocgrpc/trace_common_test.go
Outdated
| @@ -21,7 +21,7 @@ import ( | |||
| "testing" | |||
| "time" | |||
|
|
|||
| testpb "go.opencensus.io/plugin/ocgrpc/testdata" | |||
| testpb "go.opencensus.io/plugin/ocgrpc/internal/testpb" | |||
There was a problem hiding this comment.
You can rename the proto package name to testpb.
rakyll
approved these changes
Mar 12, 2018
semistrict
force-pushed
the
rename-testdata
branch
from
8851e46
to
d1b35a0
Compare
semistrict
force-pushed
the
rename-testdata
branch
from
d1b35a0
to
db653b8
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #549