Skip to content
This repository has been archived by the owner on Oct 3, 2023. It is now read-only.

Update dependency jaeger-client to ~3.15.0 #550

Merged
merged 2 commits into from
May 29, 2019

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented May 24, 2019

This PR contains the following updates:

Package Type Update Change References
jaeger-client dependencies minor ~3.14.0 -> ~3.15.0 source

Release Notes

jaegertracing/jaeger-client-node

v3.15.0

Compare Source


Renovate configuration

📅 Schedule: "after 9am and before 3pm" (UTC).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Whenever PR is stale, or if you modify the PR title to begin with "rebase!".

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot. View repository job log here.

@renovate
Copy link
Contributor Author

renovate bot commented May 24, 2019

PR has been edited

👷 This PR has received other commits, so Renovate will stop updating it to avoid conflicts or other problems. If you wish to abandon your changes and have Renovate start over you may click the "rebase" checkbox in the PR body/description.

@mayurkale22
Copy link
Member

The build failure is because of jaegertracing/jaeger-client-node#340, Utils.ipToInt function is removed in the latest version, the library expects the node client to send ip in dot format and not in signed int32.

@codecov-io
Copy link

codecov-io commented May 28, 2019

Codecov Report

Merging #550 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #550      +/-   ##
==========================================
- Coverage   95.25%   95.23%   -0.02%     
==========================================
  Files         147      147              
  Lines       10470    10433      -37     
  Branches      739      735       -4     
==========================================
- Hits         9973     9936      -37     
  Misses        497      497
Impacted Files Coverage Δ
src/detect-resource.ts 66.66% <0%> (-24.25%) ⬇️
test/test-detect-resource.ts 93.84% <0%> (-5.19%) ⬇️
src/stackdriver-monitoring.ts 77.02% <0%> (-2.71%) ⬇️
src/grpc-stats/server-stats.ts 100% <0%> (ø) ⬆️
src/resource-labels.ts 100% <0%> (ø) ⬆️
...c/zpages-frontend/controllers/tracez.controller.ts 100% <0%> (ø) ⬆️
...es-frontend/controllers/traceconfigz.controller.ts 100% <0%> (ø) ⬆️
src/grpc-stats/client-stats.ts 100% <0%> (ø) ⬆️
src/zpages-frontend/controllers/rpcz.controller.ts 100% <0%> (ø) ⬆️
test/test-prometheus-stats.ts 100% <0%> (ø) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca0e962...f3483f2. Read the comment docs.

@mayurkale22
Copy link
Member

@draffensperger Please review, I have edited the renovate PR to fix the build.

@mayurkale22 mayurkale22 merged commit 367db52 into master May 29, 2019
@mayurkale22 mayurkale22 deleted the renovate/jaeger-client-3.x branch May 29, 2019 00:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants