Skip to content
This repository has been archived by the owner on Sep 13, 2022. It is now read-only.

Transform IP from int32 representation to dot representation #340

Merged
merged 1 commit into from
Jan 29, 2019
Merged

Transform IP from int32 representation to dot representation #340

merged 1 commit into from
Jan 29, 2019

Conversation

Etienne-Carriere
Copy link
Contributor

Which problem is this PR solving?

@Etienne-Carriere Etienne-Carriere changed the title Transform IP for int32 representation to dot representation Transform IP from int32 representation to dot representation Jan 29, 2019
Copy link
Contributor

@black-adder black-adder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we remove Utils.ipToInt completely? I don't think we use it anywhere else

@Etienne-Carriere
Copy link
Contributor Author

It is indeed no more used .

@codecov
Copy link

codecov bot commented Jan 29, 2019

Codecov Report

Merging #340 into master will increase coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #340      +/-   ##
==========================================
+ Coverage   99.07%   99.12%   +0.05%     
==========================================
  Files          43       43              
  Lines        1725     1713      -12     
  Branches      338      336       -2     
==========================================
- Hits         1709     1698      -11     
+ Misses         16       15       -1
Impacted Files Coverage Δ
src/util.js 100% <ø> (+1.42%) ⬆️
src/tracer.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0f9e53...0fd08fc. Read the comment docs.

Copy link
Contributor

@black-adder black-adder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cheers!

@black-adder black-adder merged commit ddf8488 into jaegertracing:master Jan 29, 2019
mayurkale22 added a commit to census-instrumentation/opencensus-node that referenced this pull request May 28, 2019
mayurkale22 added a commit to census-instrumentation/opencensus-node that referenced this pull request May 28, 2019
mayurkale22 pushed a commit to census-instrumentation/opencensus-node that referenced this pull request May 29, 2019
* Update dependency jaeger-client to ~3.15.0

* Fix build - jaegertracing/jaeger-client-node#340
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants