Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rbox mail optimizations: #233

Closed
jrse opened this issue Jan 17, 2019 · 0 comments
Closed

rbox mail optimizations: #233

jrse opened this issue Jan 17, 2019 · 0 comments
Assignees
@jrse
Labels
enhancement

Comments

@jrse
Copy link
Contributor

jrse commented Jan 17, 2019

  • access to rados_mail metadata
  • minimize rados_mail object
  • use readOperation to read and stat mail object
  • use WriteOperation correctly (batching).
jrse added a commit that referenced this issue Jan 17, 2019
@jrse
#233: access to mail_metadata in rados_mail, readOperation, writeOper…
3ea9ec3 
…ations
jrse added a commit that referenced this issue Jan 17, 2019
@jrse
#233: removed operations/completion map from rados_mail. changed api …
8d50d3c 
…function wait_for_write_opertations_complete. fix build
jrse added a commit that referenced this issue Jan 17, 2019
@jrse
#233: cleanup completion and writeOperation
84c5f35
jrse added a commit that referenced this issue Jan 17, 2019
@jrse
#233: unit test fix; write \0 to metadata (xattr).
a427721
jrse added a commit that referenced this issue Jan 18, 2019
@jrse
#233: unit test did not save xattr with \0 terminator
0d657fe
jrse added a commit that referenced this issue Jan 18, 2019
@jrse
#233: in case rbox-copy failed, rados_mail object was not freed. Remo…
2a7cb73 
…ved some logging.
jrse added a commit that referenced this issue Jan 18, 2019
@jrse
#233: fix missing \0 when reading xattr_ directly.
6069276
jrse added a commit that referenced this issue Jan 18, 2019
@jrse
#233: added \0 termination for xattributes
23b5394
jrse added a commit that referenced this issue Jan 18, 2019
@jrse
#233: fix get_metadata char* not initialized, check for null value
fde29ea
jrse added a commit that referenced this issue Jan 18, 2019
@jrse
#233: added TODO comment: get_metadata is duplicate (-> see rados-mai…
23628b1 
…l.h)
jrse added a commit that referenced this issue Jan 18, 2019
@jrse
#233: get_cmd: mail_obj->get_oid() returns ptr to oid name (refactori…
825c9e6 
…ng), but we need the string value for the local filename
jrse added a commit that referenced this issue Jan 18, 2019
@jrse
#233: added TODO: load metadata: currently for every object a new wri…
183b145 
…te operation is created. get_metadata without initialized char*. check for nullptr before using loaded metadata
jrse added a commit that referenced this issue Jan 18, 2019
@jrse
#233: in case copy fails due to object does not exist. allocated mail…
3de64f3 
…_object was not freed
jrse added a commit that referenced this issue Jan 18, 2019
@jrse
#233: copy char* in get_metadata. Dovecots memory managment will free it
386c9a5
jrse added a commit that referenced this issue Jan 18, 2019
@jrse
#233: removed (dumy) cached recv.date and guid
b40e26b
jrse added a commit that referenced this issue Jan 18, 2019
@jrse
#233: invalid check for uid. => master did it right. UID of copy need…
4c53f8b 
…s to be different as source.
jrse added a commit that referenced this issue Jan 18, 2019
@jrse
#233: Mail metadata guid: if copied directly (ceph cluster) the guid …
a2ce770 
…of copy is equal to source. This currently not the case with lda and doveadm copy. mdbox uses guid to create references instead of copying the mailobject.
jrse added a commit that referenced this issue Jan 18, 2019
@jrse
#233: always free value* (get_cached_metadata)
8717def
jrse added a commit that referenced this issue Jan 22, 2019
@jrse
#233: load metadata did not reload already loaded metadata, this lead…
bd0023d 
… in some cases e.g. receive_date to non existent receivedates.
jrse added a commit that referenced this issue Jan 22, 2019
@jrse
#233: guid needs to be equal if copied from lda or with doveadm
6aaf516
jrse added a commit that referenced this issue Jan 22, 2019
@jrse
#233: new unit test check metadata
2964db8
jrse added a commit that referenced this issue Jan 22, 2019
@jrse
#233: removed aioRemove and completions
13bf9bc
jrse added a commit that referenced this issue Jan 22, 2019
@jrse
#233: removed debug messages
7a994c8
jrse added a commit that referenced this issue Jan 22, 2019
@jrse
#233: write \0 to end of mail. modified test read_mail to check for \0
e230ade
jrse added a commit that referenced this issue Jan 22, 2019
@jrse
#233: do not increase mail_size if buffer was modified by zlib.
83da2d0
jrse added a commit that referenced this issue Jan 23, 2019
@jrse
#233: removed debug messages
957b39a
@jrse jrse self-assigned this Jan 23, 2019
jrse added a commit that referenced this issue Jan 23, 2019
@jrse
#233: fix pop3 imaptest issues (Fatal error) #235
79aea59
jrse added a commit that referenced this issue Jan 23, 2019
@jrse
Merge pull request #235 from ceph-dovecot/optimizations_jrse
c86703b 
PR: Code Cleanup #233, #234 and missing \0 for mail metadata and mail (if not compressed)
@jrse jrse closed this as completed Jan 23, 2019
@jrse jrse mentioned this issue Jan 23, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jrse jrse

Labels
enhancement
Projects
Dovecot Ceph Plugin release candidate
Status: Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jrse