PR: Code Cleanup #233, #234 and missing \0 for mail metadata and mail (if not compressed) #235

jrse · 2019-01-23T08:51:52Z

No description provided.

…ations

…function wait_for_write_opertations_complete. fix build

…ved some logging.

…l.h)

…ng), but we need the string value for the local filename

…te operation is created. get_metadata without initialized char*. check for nullptr before using loaded metadata

…_object was not freed

…s to be different as source.

…of copy is equal to source. This currently not the case with lda and doveadm copy. mdbox uses guid to create references instead of copying the mailobject.

… in some cases e.g. receive_date to non existent receivedates.

jrse added 30 commits January 17, 2019 09:21

#233: access to mail_metadata in rados_mail, readOperation, writeOper…

3ea9ec3

…ations

#233: removed operations/completion map from rados_mail. changed api …

8d50d3c

…function wait_for_write_opertations_complete. fix build

#233: cleanup completion and writeOperation

84c5f35

#233: unit test fix; write \0 to metadata (xattr).

a427721

233: fix build

51fe61e

233: fix build missing \0 for bufferlist value

ef4e8e2

233: modified unit tests to match \0 termination for xattributes

05b7d4d

#233: unit test did not save xattr with \0 terminator

0d657fe

#233: in case rbox-copy failed, rados_mail object was not freed. Remo…

2a7cb73

…ved some logging.

#233: fix missing \0 when reading xattr_ directly.

6069276

#233: added \0 termination for xattributes

23b5394

#233: fix get_metadata char* not initialized, check for null value

fde29ea

#233: added TODO comment: get_metadata is duplicate (-> see rados-mai…

23628b1

…l.h)

#233: get_cmd: mail_obj->get_oid() returns ptr to oid name (refactori…

825c9e6

…ng), but we need the string value for the local filename

#233: added TODO: load metadata: currently for every object a new wri…

183b145

…te operation is created. get_metadata without initialized char*. check for nullptr before using loaded metadata

#233: in case copy fails due to object does not exist. allocated mail…

3de64f3

…_object was not freed

#233: copy char* in get_metadata. Dovecots memory managment will free it

386c9a5

#233: removed (dumy) cached recv.date and guid

b40e26b

#233: invalid check for uid. => master did it right. UID of copy need…

4c53f8b

…s to be different as source.

#233: Mail metadata guid: if copied directly (ceph cluster) the guid …

a2ce770

…of copy is equal to source. This currently not the case with lda and doveadm copy. mdbox uses guid to create references instead of copying the mailobject.

#233: always free value* (get_cached_metadata)

8717def

#233: load metadata did not reload already loaded metadata, this lead…

bd0023d

… in some cases e.g. receive_date to non existent receivedates.

#233: guid needs to be equal if copied from lda or with doveadm

6aaf516

#233: new unit test check metadata

2964db8

#233: removed aioRemove and completions

13bf9bc

#233: removed debug messages

7a994c8

#233: write \0 to end of mail. modified test read_mail to check for \0

e230ade

#234: use obox header to read mail guid metadata

5ec574d

#233: do not increase mail_size if buffer was modified by zlib.

83da2d0

#233: removed debug messages

957b39a

#233: fix pop3 imaptest issues (Fatal error) #235

79aea59

jrse merged commit c86703b into master Jan 23, 2019

jrse deleted the optimizations_jrse branch January 23, 2019 11:57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

PR: Code Cleanup #233, #234 and missing \0 for mail metadata and mail (if not compressed) #235

PR: Code Cleanup #233, #234 and missing \0 for mail metadata and mail (if not compressed) #235

jrse commented Jan 23, 2019

PR: Code Cleanup #233, #234 and missing \0 for mail metadata and mail (if not compressed) #235

PR: Code Cleanup #233, #234 and missing \0 for mail metadata and mail (if not compressed) #235

Conversation

jrse commented Jan 23, 2019