Fix some smaller issues #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Danny Al-Gaaf <[email protected]>
Signed-off-by: Danny Al-Gaaf <[email protected]>
Fix for: [src/librmb/rados-namespace-manager.h:31]: (warning) Redundant assignment of 'this->oid_suffix' to itself. Signed-off-by: Danny Al-Gaaf <[email protected]>
Fix for: [src/librmb/rados-cluster-impl.cpp:79]: (style) Condition 'ret==0' is always true Signed-off-by: Danny Al-Gaaf <[email protected]>
Fix for: [src/storage-rbox/rbox-mailbox-list-fs.cpp:97]: (style) Statements following return, break, continue, goto or throw will never be executed. [src/storage-rbox/rbox-mailbox-list-fs.cpp:255]: (style) Statements following return, break, continue, goto or throw will never be executed. Signed-off-by: Danny Al-Gaaf <[email protected]>
Fix for: [src/librmb/tools/rmb/rmb.cpp:576]: (style) Checking if unsigned variable 'args.size()' is less than zero. [src/librmb/tools/rmb/rmb.cpp:576]: (style) Checking if unsigned variable 'opts.size()' is less than zero. Signed-off-by: Danny Al-Gaaf <[email protected]>
Signed-off-by: Danny Al-Gaaf <[email protected]>
|
Are these build issues even related to the code changes? |
|
no the current build issues are related to additional doveadm backup tests. I'm currently working on this problem. |
jrse
approved these changes
May 17, 2018
|
who will merge it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.