Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some smaller issues #141

Merged
merged 7 commits into from
May 23, 2018
Merged

Fix some smaller issues #141

merged 7 commits into from
May 23, 2018

Commits on May 16, 2018

  1. README.md: add dovecot-devel to the required packages for build 

    Signed-off-by: Danny Al-Gaaf <[email protected]>
    @dalgaaf
    dalgaaf committed May 16, 2018
    Configuration menu
    Copy the full SHA
    357f204 View commit details
    Browse the repository at this point in the history

  2. README.md: set libjansson-devel as requirement for build 

    Signed-off-by: Danny Al-Gaaf <[email protected]>
    @dalgaaf
    dalgaaf committed May 16, 2018
    Configuration menu
    Copy the full SHA
    85073f4 View commit details
    Browse the repository at this point in the history

  3. librmb: fix self assignment, assign function argument 

    Fix for:

[src/librmb/rados-namespace-manager.h:31]: (warning) Redundant
 assignment of 'this->oid_suffix' to itself.

Signed-off-by: Danny Al-Gaaf <[email protected]>
    @dalgaaf
    dalgaaf committed May 16, 2018
    Configuration menu
    Copy the full SHA
    c380533 View commit details
    Browse the repository at this point in the history

  4. librmb/rados-cluster-impl.cpp: remove always true check 

    Fix for:

[src/librmb/rados-cluster-impl.cpp:79]: (style) Condition 'ret==0' is
 always true

Signed-off-by: Danny Al-Gaaf <[email protected]>
    @dalgaaf
    dalgaaf committed May 16, 2018
    Configuration menu
    Copy the full SHA
    f002b73 View commit details
    Browse the repository at this point in the history

  5. storage-rbox: remove return before debug call 

    Fix for:

[src/storage-rbox/rbox-mailbox-list-fs.cpp:97]: (style) Statements
 following return, break, continue, goto or throw will never be executed.
[src/storage-rbox/rbox-mailbox-list-fs.cpp:255]: (style) Statements
 following return, break, continue, goto or throw will never be executed.

Signed-off-by: Danny Al-Gaaf <[email protected]>
    @dalgaaf
    dalgaaf committed May 16, 2018
    Configuration menu
    Copy the full SHA
    a82dfe7 View commit details
    Browse the repository at this point in the history

  6. librmb/tools/rmb/rmb.cpp: use empty() over size() <= 0 

    Fix for:

[src/librmb/tools/rmb/rmb.cpp:576]: (style) Checking if
 unsigned variable 'args.size()' is less than zero.
[src/librmb/tools/rmb/rmb.cpp:576]: (style) Checking if
 unsigned variable 'opts.size()' is less than zero.

Signed-off-by: Danny Al-Gaaf <[email protected]>
    @dalgaaf
    dalgaaf committed May 16, 2018
    Configuration menu
    Copy the full SHA
    c19ec3d View commit details
    Browse the repository at this point in the history

  7. storage-rbox: Prefer prefix ++/-- operators for non-primitive types 

    Signed-off-by: Danny Al-Gaaf <[email protected]>
    @dalgaaf
    dalgaaf committed May 16, 2018
    Configuration menu
    Copy the full SHA
    e77870f View commit details
    Browse the repository at this point in the history