Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix right button of TextField component shrinking bug #2375

Merged

Conversation

yangwooseong
Copy link
Collaborator

Self Checklist

  • I wrote a PR title in English and added an appropriate label to the PR.
  • I wrote the commit message in English and to follow the Conventional Commits specification.
  • I added the changeset about the changes that needed to be released. (or didn't have to)
  • I wrote or updated documentation related to the changes. (or didn't have to)
  • I wrote or updated tests related to the changes. (or didn't have to)
  • I tested the changes in various browsers. (or didn't have to)
    • Windows: Chrome, Edge, (Optional) Firefox
    • macOS: Chrome, Edge, Safari, (Optional) Firefox

Related Issue

Summary

  • TextField의 rightContent로 오는 컴포넌트의 width 가 고정되는 버그를 수정합니다.

Details

As-is To-be
image image

Breaking change? (Yes/No)

  • No

References

  • None

@yangwooseong yangwooseong added the fix PR related to bug fix label Jul 22, 2024
@yangwooseong yangwooseong self-assigned this Jul 22, 2024
Copy link

changeset-bot bot commented Jul 22, 2024

🦋 Changeset detected

Latest commit: c3ee169

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@channel.io/bezier-react Patch
bezier-figma-plugin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

channeltalk bot commented Jul 22, 2024

Copy link
Contributor

Chromatic Report

🚀 Congratulations! Your build was successful!

Copy link

codecov bot commented Jul 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.86%. Comparing base (82a0243) to head (c3ee169).
Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2375   +/-   ##
=======================================
  Coverage   83.86%   83.86%           
=======================================
  Files         140      140           
  Lines        2919     2919           
  Branches      879      892   +13     
=======================================
  Hits         2448     2448           
+ Misses        466      441   -25     
- Partials        5       30   +25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yangwooseong yangwooseong merged commit 00e7f17 into channel-io:main Aug 2, 2024
9 checks passed
@yangwooseong yangwooseong deleted the WEB-3106/rm-textfield-fixed-width branch August 2, 2024 02:47
yangwooseong pushed a commit that referenced this pull request Aug 5, 2024
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## @channel.io/[email protected]

### Patch Changes

- Deprecate `imageUrl` props of `Emoji` component.
([#2400](#2400)) by
@yangwooseong

- Fix `OutlineItem` component's icon size and gap between icon and
leftContent.
([#2403](#2403)) by
@yangwooseong

- Prevent right button of `TextField` from shrinking.
([#2375](#2375)) by
@yangwooseong

- Keep the color of text when hovering over the tertiary `Button`
component.
([#2381](#2381)) by
@yangwooseong

## [email protected]

### Patch Changes

-   Updated dependencies
    -   @channel.io/[email protected]

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix PR related to bug fix
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Remove fixed width of right item in TextField component
2 participants