-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate imageUrl
props in Emoji
component
#2400
Deprecate imageUrl
props in Emoji
component
#2400
Conversation
🦋 Changeset detectedLatest commit: 4b204e5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
args: { | ||
size: '24', | ||
imageUrl: MOCK_EMOJI_URL, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
name이 required임에도 불구하고 타입에러가 나지 않고 있었습니다. satisfies 를 사용하면 이를 방지할 수 있습니다.
Chromatic Report🚀 Congratulations! Your build was successful! |
3c10b3e
to
4b204e5
Compare
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @channel.io/[email protected] ### Patch Changes - Deprecate `imageUrl` props of `Emoji` component. ([#2400](#2400)) by @yangwooseong - Fix `OutlineItem` component's icon size and gap between icon and leftContent. ([#2403](#2403)) by @yangwooseong - Prevent right button of `TextField` from shrinking. ([#2375](#2375)) by @yangwooseong - Keep the color of text when hovering over the tertiary `Button` component. ([#2381](#2381)) by @yangwooseong ## [email protected] ### Patch Changes - Updated dependencies - @channel.io/[email protected] Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Self Checklist
Related Issue
imageUrl
and get url fromname
props inEmoji
component #2335Summary
Emoji
컴포넌트에서 url 을 직접 받는 로직을 제거하고 컴포넌트 내부에서name
,size
속성으로부터 url 을 만드는 것으로 변경합니다.Details
name
타입을 아이콘 이름의 union type(e.g. 'smiley' | 'grinning' | ... )으로 좁히지 않았습니다.Breaking change? (Yes/No)
References