Deprecate imageUrl props in Emoji component
#2400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yangwooseong
added
the
enhancement
🦋 Changeset detectedLatest commit: 4b204e5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
yangwooseong
commented
Aug 1, 2024
| args: { | ||
| size: '24', | ||
| imageUrl: MOCK_EMOJI_URL, |
There was a problem hiding this comment.
name이 required임에도 불구하고 타입에러가 나지 않고 있었습니다. satisfies 를 사용하면 이를 방지할 수 있습니다.
Chromatic Report🚀 Congratulations! Your build was successful! |
sungik-choi
approved these changes
Aug 1, 2024
yangwooseong
force-pushed
the
WEB-3488/deprecate-image-url
branch
from
3c10b3e
to
4b204e5
Compare
yangwooseong
pushed a commit
that referenced
this pull request
Aug 5, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @channel.io/[email protected] ### Patch Changes - Deprecate `imageUrl` props of `Emoji` component. ([#2400](#2400)) by @yangwooseong - Fix `OutlineItem` component's icon size and gap between icon and leftContent. ([#2403](#2403)) by @yangwooseong - Prevent right button of `TextField` from shrinking. ([#2375](#2375)) by @yangwooseong - Keep the color of text when hovering over the tertiary `Button` component. ([#2381](#2381)) by @yangwooseong ## [email protected] ### Patch Changes - Updated dependencies - @channel.io/[email protected] Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Self Checklist
Related Issue
imageUrland get url fromnameprops inEmojicomponent #2335Summary
Emoji컴포넌트에서 url 을 직접 받는 로직을 제거하고 컴포넌트 내부에서name,size속성으로부터 url 을 만드는 것으로 변경합니다.Details
name타입을 아이콘 이름의 union type(e.g. 'smiley' | 'grinning' | ... )으로 좁히지 않았습니다.Breaking change? (Yes/No)
References