Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: snakecase to kebab for diffexp-may-be-slow #2687

Merged
merged 2 commits into from
Sep 5, 2024

Conversation

tihuan
Copy link
Contributor

@tihuan tihuan commented Sep 4, 2024

The variable diffexp_may_be_slow is set within the python server and used within the javascript client as another variable diffexp-may-be-slow. This PR fixes this divergence and uses a single variable name. The introduced changes have been tested locally and indeed fix the issue that the warning when hovering the DEG button was not shown previously with large datasets.

Original PR: #2678

All credit goes to: @moritzschaefer 🙏

@tihuan
Copy link
Contributor Author

tihuan commented Sep 4, 2024

This PR is currently blocked by #2685, since that PR fixes all the tests that are failing in this PR 👌

Copy link

codecov bot commented Sep 5, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 70.52%. Comparing base (7bf5add) to head (7d18d8d).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
server/data_anndata/anndata_adaptor.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2687   +/-   ##
=======================================
  Coverage   70.52%   70.52%           
=======================================
  Files          96       96           
  Lines        6654     6654           
  Branches      769      769           
=======================================
  Hits         4693     4693           
  Misses       1885     1885           
  Partials       76       76           
Flag Coverage Δ
frontend 70.52% <50.00%> (ø)
javascript 70.52% <50.00%> (ø)
unitTest 70.52% <50.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tihuan tihuan requested a review from kaloster September 5, 2024 17:03
@tihuan tihuan merged commit c425d2e into main Sep 5, 2024
10 checks passed
@tihuan tihuan deleted the thuang-snake-case-to-kebab branch September 5, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants