Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: snakecase to kebab for diffexp-may-be-slow #2687

Merged
merged 2 commits into from
Sep 5, 2024
Merged

fix: snakecase to kebab for diffexp-may-be-slow #2687

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
80ec929
fix: underscore snakecase notation to hyphenated snakecase for diffex…
tihuan Sep 4, 2024
7d18d8d
Merge branch 'main' into thuang-snake-case-to-kebab
tihuan Sep 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion server/common/config/dataset_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,7 @@ def handle_diffexp(self, context):
self.validate_correct_type_of_configuration_attribute("diffexp__top_n", int)

data_adaptor = self.get_data_adaptor()
if self.diffexp__enable and data_adaptor.parameters.get("diffexp_may_be_slow", False):
if self.diffexp__enable and data_adaptor.parameters.get("diffexp-may-be-slow", False):
context["messagefn"](
"CAUTION: due to the size of your dataset, " "running differential expression may take longer or fail."
)
Expand Down
2 changes: 1 addition & 1 deletion server/data_anndata/anndata_adaptor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,7 @@
# heuristic
n_values = self.data.shape[0] * self.data.shape[1]
if (n_values > 1e8 and self.server_config.adaptor__anndata_adaptor__backed is True) or (n_values > 5e8):
self.parameters.update({"diffexp_may_be_slow": True})
self.parameters.update({"diffexp-may-be-slow": True})

Check warning on line 214 in server/data_anndata/anndata_adaptor.py

View check run for this annotation

Codecov / codecov/patch

server/data_anndata/anndata_adaptor.py#L214 

Added line #L214 was not covered by tests

def _is_valid_layout(self, arr):
"""return True if this layout data is a valid array for front-end presentation:
Expand Down
Loading