Inverted time scale functionality added - Issue #3279 #5731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes issue chartjs#3279 where when scale type is time and the ticks option has reverse as true, it wouldn't reverse the scale. I have added combined various tests such as reversing when distribution is linear and series.
|
I am unable to fix some of the issue because of the foundation of the code setup. Please let me know if I could do anything else for the approval |
benmccann
reviewed
Sep 27, 2018
| @@ -132,6 +132,46 @@ function buildLookupTable(timestamps, min, max, distribution) { | |||
| return table; | |||
| } | |||
|
|
|||
| /** | |||
| * Has the same functionatilites as `buildLookupTable` but this functions | |||
There was a problem hiding this comment.
functionatilites -> functionalities
|
I'm wondering if we actually need the reverse lookup table. Would it instead be possible to do something like |
|
I tried doing what you asked but it doesnt seem to work |
|
@priteshkadiwala thank for your contribution, we merged #5927 instead which contain no code duplication. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue #3279 where when scale type is time and the ticks option has reverse as true, it wouldn't reverse the scale. I have combined various tests such as reversing when distribution is linear and series too.