Add reverse support to time scale
#5927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etimberg
previously approved these changes
Dec 19, 2018
benmccann
previously approved these changes
Dec 20, 2018
simonbrunel
reviewed
Dec 20, 2018
actually reverse the ticks, to be combatible with other implementations revert change to core.scale.js (not needed anymore)
|
Changed start to end as @simonbrunel suggested and noticed and fixed a issue.
|
|
Does it work correctly with other |
|
etimberg
approved these changes
Dec 20, 2018
Closed
This was referenced Mar 4, 2020
This was referenced Mar 9, 2020
exwm
pushed a commit
to exwm/Chart.js
that referenced
this pull request
Apr 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simpler approach for reversing time scale.
What I don't know is why those labels rotate, that needs to be investigated still.Tests adopted from PR: #5731
(tick rotation fixed in fiddle)
2.7.3: https://jsfiddle.net/rr3ftzge/40/
PR: https://jsfiddle.net/9cr418ty/1/
Updated PR: https://jsfiddle.net/9cr418ty/2/
Closes #5731
Fixes #3279