Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated to Kafka 0.10.1.1 and deprecated old API. #43

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

vbence
Copy link

@vbence vbence commented Jan 5, 2017

Code examples also updated.

@Xaerxess
Copy link
Contributor

@chbatey Any chance this PR would be merged soon? Also, since it changes API, it could (should?) be release as kafka-unit-1.0.

@Xaerxess
Copy link
Contributor

@chbatey We'd like to prepare new version with Kafka 0.11 support, should we make PR branching from master or from this branch (and then prepare 0.8 release)?

@chbatey
Copy link
Owner

chbatey commented Aug 21, 2017

Hi @Xaerxess

If you can rebase I can release a new version this this

@Xaerxess
Copy link
Contributor

@chbatey Maybe first release new version 0.7, which will include all recent merged changes and bump to 0.10.2, and then I rebase this PR bumping Kafka to 0.11 (and changing API from KeyedMessage to ProducerRecord, which is breaking change for existing tests (which may suggest you want publish that as kafka-unit 1.0).

@chbatey
Copy link
Owner

chbatey commented Aug 29, 2017

@Xaerxess 0.7 is released now so you can do your rebase, thanks and sorry for the delay

@Qnzvna Qnzvna mentioned this pull request Oct 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants