Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/bump kafka version #58

Merged
merged 4 commits into from
Dec 21, 2017

Conversation

Qnzvna
Copy link
Contributor

@Qnzvna Qnzvna commented Aug 31, 2017

bumping kafka version to kafka_2.11:0.11.0.0, zookeeper to 3.4.10, using ProducerRecord instead of depreacated KeyedMessage

* removing deprecated kafka API
* topic is not created automatically when sending messages
@Qnzvna Qnzvna force-pushed the feature/bump_kafka_version branch 2 times, most recently from c7c64ef to 5b9fc1f Compare September 25, 2017 18:02
@Qnzvna
Copy link
Contributor Author

Qnzvna commented Oct 5, 2017

@chbatey Could you review this PR, I've removed deprecated API and upgraded kafka to the newest version.
That PR will close #60 and #43

@Qnzvna
Copy link
Contributor Author

Qnzvna commented Dec 16, 2017

Could we merge this as new version of kafka should be supported.

@chbatey
Copy link
Owner

chbatey commented Dec 21, 2017

Looks good 👍

@chbatey chbatey merged commit c735fb0 into chbatey:master Dec 21, 2017
@Qnzvna
Copy link
Contributor Author

Qnzvna commented Dec 21, 2017

When are you planning to do the release of 1.0?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants