Update tests #4
Merged
Update tests #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnnypham
commented
Feb 8, 2021
| @@ -242,7 +242,6 @@ public override byte[] EncryptColumnEncryptionKey(string masterKeyPath, string e | |||
| { | |||
| // Validate the input parameters | |||
| ValidateNonEmptyAKVPath(masterKeyPath, isSystemOp: true); | |||
| ValidateNotNullOrWhitespace(encryptionAlgorithm, nameof(encryptionAlgorithm)); | |||
There was a problem hiding this comment.
ValidateEncryptionAlgorithm() already validates if encryptionAlgorithm is null or not equal to "RSA_OAEP".
johnnypham
commented
Feb 8, 2021
| @@ -214,11 +214,11 @@ internal static string InvalidSignatureTemplate | |||
| /// <summary> | |||
| /// Looks up a localized string similar to Invalid trusted endpoint specified: '{0}'; a trusted endpoint must have a value.. | |||
| /// </summary> | |||
| internal static string InvalidTrustedEndpointTemplate | |||
| internal static string NullOrWhitespaceForEach | |||
There was a problem hiding this comment.
Made this a more generic validator, same as in the AAP SDK.
johnnypham
commented
Feb 8, 2021
| @@ -107,7 +107,7 @@ static DataTestUtility() | |||
| } | |||
|
|
|||
| AKVOriginalUrl = c.AzureKeyVaultURL; | |||
| if (!string.IsNullOrEmpty(AKVOriginalUrl) && Uri.TryCreate(AKVOriginalUrl, UriKind.Absolute, out Uri AKVBaseUri)) | |||
There was a problem hiding this comment.
This was creating a new local variable and not updating the static field in DataTestUtility. When the static AKVBaseUri was used later to instantiate a KeyClient, it was null.
johnnypham
commented
Feb 9, 2021
| @@ -117,8 +117,8 @@ | |||
| <resheader name="writer"> | |||
| <value>System.Resources.ResXResourceWriter, System.Windows.Forms, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089</value> | |||
| </resheader> | |||
| <data name="InvalidTrustedEndpointTemplate" xml:space="preserve"> | |||
| <value>Invalid trusted endpoint specified: '{0}'; a trusted endpoint must have a value.</value> | |||
There was a problem hiding this comment.
A null or empty endpoint couldn't be interpolated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.