-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update tests #4
Update tests #4
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -117,8 +117,8 @@ | |
<resheader name="writer"> | ||
<value>System.Resources.ResXResourceWriter, System.Windows.Forms, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089</value> | ||
</resheader> | ||
<data name="InvalidTrustedEndpointTemplate" xml:space="preserve"> | ||
<value>Invalid trusted endpoint specified: '{0}'; a trusted endpoint must have a value.</value> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. A null or empty endpoint couldn't be interpolated. |
||
<data name="NullOrWhitespaceForEach" xml:space="preserve"> | ||
<value>One or more of the elements in {0} are null or empty or consist of only whitespace.</value> | ||
</data> | ||
<data name="CipherTextLengthMismatch" xml:space="preserve"> | ||
<value>CipherText length does not match the RSA key size.</value> | ||
|
@@ -174,4 +174,4 @@ | |
<data name="NullAlgorithmInternal" xml:space="preserve"> | ||
<value>Internal error. Key encryption algorithm cannot be null.</value> | ||
</data> | ||
</root> | ||
</root> |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -107,7 +107,7 @@ static DataTestUtility() | |
} | ||
|
||
AKVOriginalUrl = c.AzureKeyVaultURL; | ||
if (!string.IsNullOrEmpty(AKVOriginalUrl) && Uri.TryCreate(AKVOriginalUrl, UriKind.Absolute, out Uri AKVBaseUri)) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This was creating a new local variable and not updating the static field in DataTestUtility. When the static |
||
if (!string.IsNullOrEmpty(AKVOriginalUrl) && Uri.TryCreate(AKVOriginalUrl, UriKind.Absolute, out AKVBaseUri)) | ||
{ | ||
AKVBaseUri = new Uri(AKVBaseUri, "/"); | ||
AKVBaseUrl = AKVBaseUri.AbsoluteUri; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ValidateEncryptionAlgorithm()
already validates ifencryptionAlgorithm
is null or not equal to "RSA_OAEP".