Merge pull request #177 from davidchambers/propagate-errors

propagate syntax errors caused by invalid selectors
cheeriojs · Mar 31, 2013 · b30a081 · b30a081
2 parents 20c108d + 504269a
commit b30a081
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 6 deletions.
diff --git a/lib/api/traversing.js b/lib/api/traversing.js
@@ -4,12 +4,7 @@ var _ = require('underscore'),
     isTag = utils.isTag;
 
 var find = exports.find = function(selector) {
-  try {
-    var elem = select(selector, [].slice.call(this.children()));
-    return this.make(elem);
-  } catch(e) {
-    return this.make([]);
-  }
+  return this.make(select(selector, [].slice.call(this.children())));
 };
 
 var parent = exports.parent = function(elem) {

diff --git a/test/api.traversing.js b/test/api.traversing.js
@@ -33,6 +33,14 @@ describe('$(...)', function() {
       expect($('#fruits').find('li')).to.have.length(0);
     });
 
+    it('should throw a SyntaxError if given an invalid selector', function() {
+      expect(function() {
+        $('#fruits').find(':bah');
+      }).to.throwException(function(err) {
+        expect(err).to.be.a(SyntaxError);
+      });
+    });
+
   });
 
   describe('.children', function() {