propagate syntax errors caused by invalid selectors

[davidchambers]

No description provided.

[matthewmueller]

hmm... not so sure about this one. the try-catch was implemented to fix some issues before.

Also, jquery fails silently. What about using something like: https://github.com/visionmedia/debug ?

[davidchambers]

jquery fails silently

No, it doesn't. Try running this in the console:

> jQuery(':bah')
Error: Syntax error, unrecognized expression: unsupported pseudo: bah

the try-catch was implemented to fix some issues before

I'll look through the commit history to see when the try/catch was added.

[davidchambers]

The try/catch was added in 8834eaa, but I don't understand why this was done. It seems unrelated to the rest of the commit.

All the tests pass (including those added in the aforementioned commit). Unless you can cite a specific reason for the try/catch to remain, Matt, I suggest we remove it.

[matthewmueller]

Oh my bad, this is just in find? I was referring to stuff like this:

#59

I think they kind of relate though.

[davidchambers]

This is just in find, yes. I'm suggesting that cheerio throw a SyntaxError when given an invalid selector (as jQuery does). All the tests pass (including the test added in #59, though I don't think that's related), so I think it's safe to make this correction.

[matthewmueller]

Okay cool. Yah I'll merge this. THanks!