Switch from Logify to mixlib-log for logging #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tas50
force-pushed
the
mixlib_log
branch
2 times, most recently
from
a42c1a0
to
9d3cdcf
Compare
Closed
afiune
approved these changes
Dec 18, 2019
Reduce the number of dependencies in our overall stack and use the same logging mechanism we use in other Chef CLI tools. This formatting matches roughly what we had before. Signed-off-by: Tim Smith <[email protected]>
Signed-off-by: Salim Afiune <[email protected]>
afiune
reviewed
Jan 29, 2020
| @@ -17,7 +17,7 @@ Cucumber::Rake::Task.new(:acceptance) do |t| | |||
| a.push('--color') | |||
| a.push('--format progress') | |||
| a.push('--strict') | |||
| a.push('--tags ~@wip') | |||
| a.push('--tags "not @wip"') | |||
There was a problem hiding this comment.
Fixed this so that we don't show this WARN message anymore:
Deprecated: Found tags option '~@wip'. Support for '~@tag' will be removed from the next release of Cucumber. Please use 'not @tag' instead.
afiune
reviewed
Jan 29, 2020
| @@ -28,6 +28,7 @@ Feature: git Plugin | |||
| * I successfully run `stove` | |||
| * the git remote should have the tag "v0.0.0" | |||
|
|
|||
| @wip | |||
There was a problem hiding this comment.
I verified master and this scenario is also failing there, I'll create a card to fix it but for now,
I have marked as @wip so that we don't run it.
afiune
reviewed
Jan 29, 2020
| log.error(e.class.name) | ||
| log.error(e.message) | ||
| log.error(e.backtrace.join("\n")) | ||
| Stove::Log.init($stderr) |
There was a problem hiding this comment.
@tas50 @tyler-ball The problem wasn't in the cucumber tests, but the actual code to log
the error to $stderr. This line fixed everything. 🥇
|
Thanks @afiune! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduces the overall number of dependencies we need to maintain and ship to customers.