Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Record all #429

Closed
RV7PR opened this issue Sep 25, 2023 · 5 comments · Fixed by #430
Closed

Record all #429

RV7PR opened this issue Sep 25, 2023 · 5 comments · Fixed by #430
Assignees
@chenxiaolong
Labels
enhancement New feature or request invalid Not a bug or invalid assumptions

Comments

@RV7PR
Copy link

RV7PR commented Sep 25, 2023

Please add back the ability to just record everything like in previous versions.
I dont want to create a rule for each contact or tap keep recording for every call because i will forget it.
@chenxiaolong
Copy link
Owner

That's already the default behavior. If you don't configure any rules, it records everything. If you already changed some rules, just make sure the All other calls option is on.

@chenxiaolong chenxiaolong self-assigned this Sep 25, 2023
@chenxiaolong chenxiaolong added the invalid Not a bug or invalid assumptions label Sep 25, 2023
@RV7PR
Copy link
Author

RV7PR commented Sep 25, 2023

@chenxiaolong Well thats weird because I never set any rules and it just stopped recording anything from 2023-05-16 after an update probably except for a few days ago because i explicitly used the keep recording in notification.
I never changed any setting nor did i add any rule and my rules were empty

@RV7PR
Copy link
Author

RV7PR commented Sep 25, 2023

@chenxiaolong Now i understand the switchers for "Unknown calls" and "All other calls" its very confusing because the description says "Delete the recording when the calls ends" which I thought that when i switch it to ON that it will delete those recordings so i never messed with that but now i see that when you switch it to ON the description changes

@chenxiaolong
Copy link
Owner

Ah, I can definitely see that being confusing. Do you have any suggestions for how to better word the description? (I'm open to making it just static text and not something that changes too.)

@chenxiaolong chenxiaolong reopened this Sep 25, 2023
@chenxiaolong chenxiaolong added the enhancement New feature or request label Sep 25, 2023
@RV7PR
Copy link
Author

RV7PR commented Sep 25, 2023

I think the best way is to indeed keep the text static so when the switch is off the recordings will be saved and when the switch is on the recordings will be deleted.

chenxiaolong added a commit that referenced this issue Sep 25, 2023
@chenxiaolong
Make auto-record rules UI more intuitive
c5dcacd 
* The rule descriptions no longer change when a rule is toggled because
  it's confusing as to whether it described the current state or what
  will happen when toggled.
* The help text has been reworded and is now shown inline instead of as
  a separate dialog box.
* `Unknown calls` and `All other calls` now have description text
  mentioning which calls they match.
* `All other calls` is now shown as `All calls` with an appropriate
  description when the Contacts permission is denied.

Fixes: #429

Signed-off-by: Andrew Gunnerson <[email protected]>
@chenxiaolong chenxiaolong mentioned this issue Sep 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chenxiaolong chenxiaolong

Labels
enhancement New feature or request invalid Not a bug or invalid assumptions
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make auto-record rules UI more intuitive chenxiaolong/BCR
2 participants
@chenxiaolong @RV7PR