Make auto-record rules UI more intuitive #430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* The rule descriptions no longer change when a rule is toggled because it's confusing as to whether it described the current state or what will happen when toggled. * The help text has been reworded and is now shown inline instead of as a separate dialog box. * `Unknown calls` and `All other calls` now have description text mentioning which calls they match. * `All other calls` is now shown as `All calls` with an appropriate description when the Contacts permission is denied. Fixes: #429 Signed-off-by: Andrew Gunnerson <[email protected]>
chenxiaolong
added a commit
that referenced
this pull request
Sep 25, 2023
Signed-off-by: Andrew Gunnerson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unknown callsandAll other callsnow have description text mentioning which calls they match.All other callsis now shown asAll callswith an appropriate description when the Contacts permission is denied.Fixes: #429