Send notification when a call recording completes #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a new notification that fires when a call recording completes successfully. It's associated with a new notification channel so it can be disabled without affecting other notifications. The notification has two action buttons: open and share. Both of these do as their name implies and do not dismiss the notification. Clicking on the notification text behaves like open, except the notification is dismissed. The open and share options require a custom ContentProvider because it's not possible to grant the target app permissions to a SAF URI. BCR's RecorderProvider is very minimal and just wraps SAF's provider for the openFile, getType, and query operations. Also, manual action from the user is required for the new open and share options to work. Previously, BCR only requested persistent write permissions to the output directory. This makes it impossible for RecorderProvider to access the recording that was just created. This commit updates the output directory permission logic to also request persistent read permissions, but the user will have to reset the output directory to the default and then select the desired directory again. Signed-off-by: Andrew Gunnerson <[email protected]>
chenxiaolong
added a commit
that referenced
this pull request
Nov 23, 2022
Signed-off-by: Andrew Gunnerson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a new notification that fires when a call recording completes successfully. It's associated with a new notification channel so it can be disabled without affecting other notifications.
The notification has two action buttons: open and share. Both of these do as their name implies and do not dismiss the notification. Clicking on the notification text behaves like open, except the notification is dismissed.
The open and share options require a custom ContentProvider because it's not possible to grant the target app permissions to a SAF URI. BCR's RecorderProvider is very minimal and just wraps SAF's provider for the openFile, getType, and query operations.
Also, manual action from the user is required for the new open and share options to work. Previously, BCR only requested persistent write permissions to the output directory. This makes it impossible for RecorderProvider to access the recording that was just created. This commit updates the output directory permission logic to also request persistent read permissions, but the user will have to reset the output directory to the default and then select the desired directory again.