Add vibrate setting on start stop recording #167
Conversation
|
Thanks for the PR! I like the idea, but would prefer to take a different approach that doesn't require new permissions. With PR #169, BCR now shows a notification when recording completes. It should be possible to have similar behavior by turning on the vibration option in Android's settings for BCR's |
|
Yeah I know it and is first thing tried, but no idea why that way not working on my Px5a. add NotificationChannel vibrateEnable vibratePattern, set IMPORTANCE_HIGH, uninstall module then re-install, allow notification bypass do not disturb....nothing can make notification vibrate work. About "doesn't require new permissions", android.permission.VIBRATE need on all ways, this permission dont need ask users, so I think it is ok. |
Android's vibration setting seemingly has no effect when the user is in a phone call, which is always the case when a BCR notification is shown. With this commit, BCR will explicitly vibrate the device using a pattern that mimics what Android does by default for notifications. This commit is inspired by @quyenvsp's PR #167, except it relies on Android notification channels' builtin vibration setting instead of adding a new setting to BCR. Related PR: #167 Signed-off-by: Andrew Gunnerson <[email protected]>
Android's vibration setting seemingly has no effect when the user is in a phone call, which is always the case when a BCR notification is shown. With this commit, BCR will explicitly vibrate the device using a pattern that mimics what Android does by default for notifications. This commit is inspired by @quyenvsp's PR #167, except it relies on Android notification channels' builtin vibration setting instead of adding a new setting to BCR. Related PR: #167 Signed-off-by: Andrew Gunnerson <[email protected]>
|
Interesting. I thought it was working properly because my smartwatch vibrated, but after disconnecting my watch, I can reproduce the problem on my Pixel 7 Pro. Can you give #171 a try? It uses the vibrator service, similar to this PR, except instead of adding a new setting, it just uses the notification channel's vibration setting. |
|
Nice, it surely better if use notification setting, will test it on my device soon 👍 |
Signed-off-by: Andrew Gunnerson <[email protected]>
No description provided.