Explicitly vibrate when vibration is enabled for a notification channel #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Android's vibration setting seemingly has no effect when the user is in a phone call, which is always the case when a BCR notification is shown. With this commit, BCR will explicitly vibrate the device using a pattern that mimics what Android does by default for notifications. This commit is inspired by @quyenvsp's PR #167, except it relies on Android notification channels' builtin vibration setting instead of adding a new setting to BCR. Related PR: #167 Signed-off-by: Andrew Gunnerson <[email protected]>
|
@chenxiaolong I tested and it work perfect, but for me vibrate one time better (like function vibrate haptic when answer/end call on Samsung), so I use pattern longArrayOf(0, 250, 250, 0). Anyway it perfect and can customize pattern 👍 |
chenxiaolong
added a commit
that referenced
this pull request
Nov 24, 2022
Signed-off-by: Andrew Gunnerson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Android's vibration setting seemingly has no effect when the user is in a phone call, which is always the case when a BCR notification is shown. With this commit, BCR will explicitly vibrate the device using a pattern that mimics what Android does by default for notifications.
This commit is inspired by @quyenvsp's PR #167, except it relies on Android notification channels' builtin vibration setting instead of adding a new setting to BCR.
Related PR: #167