Support Tile Clusters (tree-like hierarchies) #3490
Conversation
There was a problem hiding this comment.
Thanks for hard working on cluster!
My only concern is the usage of Clone, which I think it should be eventually removed in the future.
We are working on the new HierarchicalCache which will be used for the COH API.
Although this will break my work, but for free to break them, I will rebase them back to dev.
| @@ -1,46 +0,0 @@ | |||
| // See LICENSE.SiFive for license details. | |||
There was a problem hiding this comment.
I don't think ClockGroupDriver make sense as well;p
Thanks for removing it.
| val csbus = tlBusWrapperLocationMap(SBUS) // like the sbus in the base subsystem | ||
| val ccbus = tlBusWrapperLocationMap(CBUS) // like the cbus in the base subsystem | ||
| val cmbus = tlBusWrapperLocationMap.lift(MBUS).getOrElse(csbus) |
There was a problem hiding this comment.
For each cluster, they should have these buses?
or we can let user directly query bus via location API.
There was a problem hiding this comment.
I will try to remove what I can here.
| crossingParams: ElementCrossingParamsLike | ||
| ) extends CanAttachCluster | ||
|
|
||
| case class CloneClusterAttachParams( |
There was a problem hiding this comment.
Basically I don't like the current Clone implementation in Diplomacy, which is a little brittle, I think in the future, we can try to remove them and use https://github.com/llvm/circt/blob/8129d5de502a8cd5d861438e99f823babc5cebb0/docs/Dialects/FIRRTL/FIRRTLAnnotations.md?plain=1#L613 to force circt do it.
There was a problem hiding this comment.
I agree the implementation of CloneLazyModule is not good right now, but I like the API of CloneLazyModule. I'm not sure what you are envisioning, but I thought the backend implementation of CloneLazyModule could change, while these APIs remain
src/main/scala/system/Configs.scala
Outdated
| class ClusterConfig extends Config( | ||
| new WithNBigCores(2, location=InCluster(3)) ++ | ||
| new WithNBigCores(2, location=InCluster(1)) ++ | ||
| new WithNBigCores(2, location=InCluster(0)) ++ | ||
| new WithCluster(3, location=InCluster(2)) ++ | ||
| new WithCluster(2) ++ | ||
| new WithCluster(1) ++ | ||
| new WithCluster(0) ++ | ||
| new DefaultConfig | ||
| ) |
jerryz123
force-pushed
the
clusters2
branch
from
f66de6a
to
8f220f1
Compare
|
@sequencer this is ready. |
#3238 rebased on latest.
This work substantially refactors the existing Tile/TilePRCIDomain/HasTiles/InstantiatesTiles code into a system that support recursive clusters of tiles.
This PR defines an
Elementas an abstract node in the hierarchy tree.Elements can beBaseTiles orClusters, whereBaseTiles are leaf nodes in the hierarchy, clusters are non-root nodes, and theBaseSubsystemis the root node.BaseTileandClusterwill support deduplication.Notably
Clusters support recursive instantiation, aClustercan containTiles or internalClusters. TheClusterbus topology should be capable of both supporting hierarchical coherence, and theBaseSubsystems topology handle managing all coherence, depending on configuration variables.This PR still requires more time. Some of the interrupt handling is not satisfying, and some decisions over clock/reset crossing ought to be addressed.
Related issue:
Type of change: bug report | feature request | other enhancement
Impact: no functional change | API addition (no impact on existing code) | API modification
Development Phase: proposal | implementation
Release Notes