-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Add rust assignmenment policy and config management #1510
Conversation
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
00a3b94
to
cb0e880
Compare
d90eea8
to
51cf2ad
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice
@@ -10,13 +10,13 @@ use thiserror::Error; | |||
use murmur3::murmur3_x64_128; | |||
|
|||
/// A trait for hashing a member and a key to a score. | |||
trait Hasher { | |||
pub(crate) trait Hasher { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note to self: pub
exports this trait from the crate. pub(crate)
makes it usable anywhere within this crate.
51cf2ad
to
c12425e
Compare
Description of changes
Summarize the changes made by this PR.
configurable
trait for static configuration of components.Box<dyn configurable>
and pass in the worker config to any components in need of configuration.Test plan
Added tests for booting the assignment policy config
cargo test
Documentation Changes
None required. Feedback welcome on in-code documentation.