Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Add rust assignmenment policy and config management #1510

Merged
merged 1 commit into from
Dec 13, 2023

Conversation

HammadB
Copy link
Collaborator

@HammadB HammadB commented Dec 12, 2023

Description of changes

Summarize the changes made by this PR.

  • Improvements & Bug fixes
    • Adds the configurable trait for static configuration of components.
    • In rust, our pattern will be that a root worker configurable object is consumed by components implementing the "Configurable" trait. Structs can then initialize themselves if the valid config exists. DI dispatch will happen by adding a dispatch type in the config.rs method of each module (not included here). Without any fancy macro programming, I think this is the best way to do it.
    • Calling code can Box<dyn configurable> and pass in the worker config to any components in need of configuration.
  • New functionality
    • Adds the rust assignment policy based on the python and go versions

Test plan

Added tests for booting the assignment policy config

  • Tests pass locally with cargo test

Documentation Changes

None required. Feedback welcome on in-code documentation.

Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readbility, Modularity, Intuitiveness)

Copy link
Contributor

@beggers beggers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@@ -10,13 +10,13 @@ use thiserror::Error;
use murmur3::murmur3_x64_128;

/// A trait for hashing a member and a key to a score.
trait Hasher {
pub(crate) trait Hasher {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to self: pub exports this trait from the crate. pub(crate) makes it usable anywhere within this crate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants