-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Add ingest dispatch + scheduler + segment #1542
Conversation
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
@@ -286,7 +305,7 @@ impl Component for PulsarIngestTopic { | |||
1000 | |||
} | |||
|
|||
fn on_start(&self, ctx: &ComponentContext<Self>) -> () { | |||
fn on_start(&mut self, ctx: &ComponentContext<Self>) -> () { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not clear to me why we need this. Does the change from an Arc
to a Box
below require that we make self
mut
here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm standardizing all the handlers to be mutable (handle, on start, future lifecycle methods etc) so users can mutate state if they desire.
a5351cd
to
23f863e
Compare
a17ae69
to
387ddf5
Compare
23f863e
to
bb999b9
Compare
387ddf5
to
54d79c5
Compare
bb999b9
to
7a9c65e
Compare
54d79c5
to
90360d2
Compare
90360d2
to
9620463
Compare
Description of changes
Summarize the changes made by this PR.
Test plan
How are these changes tested?
cargo test
Apologies for the larger diff, my stack got messed up