-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG]: Fix for failing chromadb-client build #1561
[BUG]: Fix for failing chromadb-client build #1561
Conversation
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
Ahhh thank you, I've been meaning to look at this for a couple days now. Does it make sense to add |
yeah, let me add it there. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noice, thank you
Coordinator tests were fixed in 7dfadf4 so merging this. |
Reverts #1561 Broke a lot of CI
## Description of changes *Summarize the changes made by this PR.* - Improvements & Bug fixes - Add `build` back as a dependency for the client. A do-over of #1561 now that main CI is passing. ## Test plan *How are these changes tested?* - [ ] Tests pass locally with `pytest` for python, `yarn test` for js ## Documentation Changes *Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the [docs repository](https://github.com/chroma-core/docs)?*
`build` was added in chroma-core#1561 to fix the build of the client. This is a build-time dependency and should not be needed at runtime. Thus it should suffice to be in `requirements-dev.txt`.
Description of changes
Summarize the changes made by this PR.
build
module is not longer available in default GH runner setup and needs to be explicitly installedTest plan
How are these changes tested?
Manual test:
Documentation Changes
N/A