Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove build from package dependencies #1639

Closed
wants to merge 1 commit into from

Conversation

xhochy
Copy link

@xhochy xhochy commented Jan 15, 2024

Description of changes

build was added in #1561 to fix the build of the client. This is a build-time dependency and should not be needed at runtime. Thus it should suffice to be in requirements-dev.txt.

Test plan

How are these changes tested?

  • Tests should pass in CI to ensure that the place in the CI pipeline that required the dependency on build correctly gets it via requirement_dev.txt and not via the package runtime dependencies.

Documentation Changes

Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs repository?

No changes in docs.

`build` was added in chroma-core#1561 to fix the build of the client. This is a build-time dependency and should not be needed at runtime. Thus it should suffice to be in `requirements-dev.txt`.
Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

Copy link
Contributor

@tazarov tazarov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I think this was added in error. It should've been in dev dependencies. Thank you @xhochy

@xhochy xhochy closed this Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants