-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Collection Configuration Storage #2338
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
Please tag your PR title with one of: [ENH | BUG | DOC | TST | BLD | PERF | TYP | CLN | CHORE]. See https://docs.trychroma.com/contributing#contributing-code-and-ideas |
This stack of pull requests is managed by Graphite. Learn more about stacking. |
atroyn
force-pushed
the
anton/parameter_management
branch
from
June 14, 2024 05:56
860971a
to
96177dc
Compare
atroyn
force-pushed
the
anton/propagate-collecton-model
branch
2 times, most recently
from
June 18, 2024 23:53
ac6b602
to
00e3a25
Compare
atroyn
force-pushed
the
anton/parameter_management
branch
from
June 18, 2024 23:53
96177dc
to
4e5d28d
Compare
atroyn
force-pushed
the
anton/propagate-collecton-model
branch
from
June 19, 2024 03:39
00e3a25
to
6d6e014
Compare
atroyn
force-pushed
the
anton/parameter_management
branch
from
June 19, 2024 03:39
4e5d28d
to
f17d07d
Compare
atroyn
force-pushed
the
anton/propagate-collecton-model
branch
from
June 20, 2024 22:28
6d6e014
to
766402a
Compare
atroyn
force-pushed
the
anton/parameter_management
branch
from
June 20, 2024 22:28
f17d07d
to
8594e00
Compare
atroyn
commented
Jun 20, 2024
atroyn
force-pushed
the
anton/parameter_management
branch
from
June 20, 2024 23:18
8594e00
to
fab77ed
Compare
atroyn
force-pushed
the
anton/propagate-collecton-model
branch
2 times, most recently
from
June 21, 2024 00:18
867fe80
to
25a5fc6
Compare
atroyn
force-pushed
the
anton/parameter_management
branch
4 times, most recently
from
June 21, 2024 00:57
dcb4cd1
to
e963f10
Compare
atroyn
force-pushed
the
anton/propagate-collecton-model
branch
from
June 21, 2024 01:42
25a5fc6
to
53058dd
Compare
atroyn
force-pushed
the
anton/parameter_management
branch
from
June 21, 2024 01:43
e963f10
to
877eb23
Compare
atroyn
force-pushed
the
anton/parameter_management
branch
from
June 21, 2024 21:06
877eb23
to
9da85c6
Compare
2 tasks
atroyn
force-pushed
the
anton/parameter_management
branch
4 times, most recently
from
July 1, 2024 23:39
fc6e457
to
1c493b7
Compare
atroyn
force-pushed
the
anton/propagate-collecton-model
branch
from
July 1, 2024 23:56
4f72a09
to
b4a93c0
Compare
atroyn
force-pushed
the
anton/parameter_management
branch
from
July 1, 2024 23:57
1c493b7
to
fbbaf20
Compare
atroyn
force-pushed
the
anton/propagate-collecton-model
branch
from
July 2, 2024 00:13
b4a93c0
to
8a6cde4
Compare
atroyn
force-pushed
the
anton/parameter_management
branch
3 times, most recently
from
July 2, 2024 00:40
72c36ec
to
68561fc
Compare
Closed
atroyn
force-pushed
the
anton/propagate-collecton-model
branch
from
July 2, 2024 17:25
8a6cde4
to
3b5338e
Compare
atroyn
force-pushed
the
anton/parameter_management
branch
from
July 2, 2024 17:26
68561fc
to
3eb0969
Compare
atroyn
force-pushed
the
anton/propagate-collecton-model
branch
from
July 2, 2024 18:18
3b5338e
to
b6d0b05
Compare
atroyn
force-pushed
the
anton/parameter_management
branch
from
July 2, 2024 18:19
3eb0969
to
c4f99e0
Compare
HammadB
approved these changes
Jul 9, 2024
atroyn
force-pushed
the
anton/propagate-collecton-model
branch
from
July 9, 2024 01:40
b6d0b05
to
b1895df
Compare
atroyn
force-pushed
the
anton/parameter_management
branch
from
July 9, 2024 01:40
3f1bc3f
to
6646c49
Compare
atroyn
force-pushed
the
anton/propagate-collecton-model
branch
from
July 9, 2024 02:02
b1895df
to
62d584f
Compare
atroyn
force-pushed
the
anton/parameter_management
branch
from
July 9, 2024 02:02
6646c49
to
ac8f122
Compare
atroyn
force-pushed
the
anton/parameter_management
branch
from
July 9, 2024 03:03
ac8f122
to
6cd3de6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This PR introduces storing collection parameters as a
Configuration
, a JSON-serializable defined object with specified configuration fields, adapting @HammadB's work in #1491.Configurations are created at creation time for collections, and are immutable thereafter.
The JSON-serialized config is stored as a new text column
config_json_str
on thecollections
table.Note that in this stack, Chroma does not actually consume the configuration for anything - this will be done in a separate stack.
This PR also updates our versions of black and mypy, which were failing with our new definitions but work with the new versions.
Test plan
Tests pass in CI except the following:
JavaScript - @jeffchuber is taking a look here.Thanks @jeffchuberDocumentation Changes
N/A - This is not a user-facing change. Documentation around migrations are later in the stack along with the cross-version persistence tests.