Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Distributed System collection config storage #2396

Merged

Conversation

atroyn
Copy link
Contributor

@atroyn atroyn commented Jun 21, 2024

Description of changes

This PR propagates the new collection configuration storage through to the distributed DB. It essentially mirrors the same change (previous in this stack) in the Local DB.

Test plan

Cluster tests pass locally and in CI.

Expected Failing:

  • Cross-version persist

Documentation Changes

N/A, use-facing migration documentation is in the next PR in this stack, with cross-version persistence.

Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

Copy link

Please tag your PR title with one of: [ENH | BUG | DOC | TST | BLD | PERF | TYP | CLN | CHORE]. See https://docs.trychroma.com/contributing#contributing-code-and-ideas

Copy link
Contributor Author

atroyn commented Jun 21, 2024

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @atroyn and the rest of your teammates on Graphite Graphite

@atroyn atroyn changed the title GRPC and protos [ENH] GRPC and protos Jun 21, 2024
@atroyn atroyn force-pushed the anton/distributed_param_management branch 2 times, most recently from 51968f7 to ac9289c Compare June 21, 2024 20:24
@atroyn atroyn changed the title [ENH] GRPC and protos [ENH] Distributed System Param Management Jun 21, 2024
@atroyn atroyn force-pushed the anton/parameter_management branch from 877eb23 to 9da85c6 Compare June 21, 2024 21:06
@atroyn atroyn force-pushed the anton/distributed_param_management branch from ac9289c to fe71e2d Compare June 21, 2024 21:06
@atroyn atroyn changed the title [ENH] Distributed System Param Management [ENH] Distributed System collection config storage Jun 22, 2024
@atroyn atroyn force-pushed the anton/parameter_management branch from 9da85c6 to 876de4c Compare June 22, 2024 01:52
@atroyn atroyn force-pushed the anton/distributed_param_management branch from fe71e2d to 50ecef5 Compare June 22, 2024 01:52
@atroyn atroyn force-pushed the anton/parameter_management branch from 876de4c to 925bf05 Compare June 22, 2024 15:30
@atroyn atroyn force-pushed the anton/distributed_param_management branch from 50ecef5 to c8f99a4 Compare June 22, 2024 15:30
@atroyn atroyn force-pushed the anton/parameter_management branch from 925bf05 to f3ea28f Compare June 23, 2024 03:49
@atroyn atroyn force-pushed the anton/distributed_param_management branch from c8f99a4 to 3781435 Compare June 23, 2024 03:49
@atroyn atroyn force-pushed the anton/parameter_management branch from f3ea28f to 3fd6646 Compare June 23, 2024 17:36
@atroyn atroyn force-pushed the anton/distributed_param_management branch from 3781435 to 9e82022 Compare June 23, 2024 17:37
@atroyn atroyn force-pushed the anton/parameter_management branch from 3fd6646 to 18956c0 Compare June 23, 2024 19:29
@atroyn atroyn force-pushed the anton/distributed_param_management branch from 9e82022 to 646b55d Compare June 23, 2024 19:29
@atroyn atroyn force-pushed the anton/parameter_management branch from 18956c0 to d44fd1d Compare June 23, 2024 19:53
@atroyn atroyn force-pushed the anton/distributed_param_management branch 6 times, most recently from c1fb6d6 to b96e4aa Compare June 24, 2024 23:15
@atroyn atroyn force-pushed the anton/parameter_management branch from d44fd1d to 3c7fe8e Compare June 25, 2024 16:26
Copy link
Collaborator

@HammadB HammadB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor test nits and we really should not reorder protos

@atroyn atroyn force-pushed the anton/parameter_management branch from a552f3c to 0a7ecae Compare June 28, 2024 15:46
@atroyn atroyn force-pushed the anton/distributed_param_management branch from 3d27445 to c55656f Compare June 28, 2024 15:46
@atroyn atroyn force-pushed the anton/parameter_management branch from 0a7ecae to 55951e7 Compare June 28, 2024 16:20
@atroyn atroyn force-pushed the anton/distributed_param_management branch 2 times, most recently from ec7dbb6 to fafcc3e Compare June 28, 2024 16:43
@atroyn atroyn force-pushed the anton/parameter_management branch from 55951e7 to b9b76dd Compare June 28, 2024 17:05
@atroyn atroyn force-pushed the anton/distributed_param_management branch from fafcc3e to 14643db Compare June 28, 2024 17:05
@atroyn atroyn force-pushed the anton/parameter_management branch from b9b76dd to 06cc918 Compare June 28, 2024 20:04
@atroyn atroyn force-pushed the anton/distributed_param_management branch from 14643db to 08ceefc Compare June 28, 2024 20:04
@atroyn atroyn force-pushed the anton/parameter_management branch from 06cc918 to befe5b2 Compare June 28, 2024 20:18
@atroyn atroyn force-pushed the anton/distributed_param_management branch from 08ceefc to 4d5edf1 Compare June 28, 2024 20:18
@atroyn atroyn force-pushed the anton/parameter_management branch from befe5b2 to fc6e457 Compare June 28, 2024 21:31
@atroyn atroyn force-pushed the anton/distributed_param_management branch from 4d5edf1 to fccf3b3 Compare June 28, 2024 21:32
@atroyn atroyn force-pushed the anton/parameter_management branch 3 times, most recently from fbbaf20 to 9dd55d1 Compare July 2, 2024 00:14
@atroyn atroyn force-pushed the anton/distributed_param_management branch 2 times, most recently from 9058466 to b2aeb97 Compare July 2, 2024 00:20
@atroyn atroyn force-pushed the anton/parameter_management branch from 9dd55d1 to 72c36ec Compare July 2, 2024 00:30
@atroyn atroyn force-pushed the anton/distributed_param_management branch from b2aeb97 to d5c265a Compare July 2, 2024 00:30
@atroyn atroyn force-pushed the anton/parameter_management branch from 72c36ec to 68561fc Compare July 2, 2024 00:40
@atroyn atroyn force-pushed the anton/distributed_param_management branch from d5c265a to a7ae5c4 Compare July 2, 2024 00:40
@atroyn atroyn mentioned this pull request Jul 2, 2024
@atroyn atroyn force-pushed the anton/parameter_management branch from 68561fc to 3eb0969 Compare July 2, 2024 17:26
@atroyn atroyn force-pushed the anton/distributed_param_management branch from a7ae5c4 to c93fc94 Compare July 2, 2024 17:26
@atroyn atroyn force-pushed the anton/parameter_management branch from 3eb0969 to c4f99e0 Compare July 2, 2024 18:19
@atroyn atroyn force-pushed the anton/distributed_param_management branch from c93fc94 to 16f3403 Compare July 2, 2024 18:19
@atroyn atroyn merged commit 16f3403 into anton/parameter_management Jul 9, 2024
60 of 66 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants