Add extra params for selectedItemComponent on trigger (power-select-multiple)
#1075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cibernox
approved these changes
Mar 11, 2018
small typo
this might be a typo as well
Sorry to submit several PRs. I create them as I encounter typos. I tried compile only one for action-handling.hbs this time tough ;-)
* stop click propagation added to the docs * added more info about stop click propagation in the docs
* Update addon to 3.1 * Smarter way to decide wether or not we want to load jquery
This PR enables Fastboot pre-rendering of the entire docs site using [prember[(https://github.com/ef4/prember). For URL discovery, it's using the newly-published [prember-crawler](https://github.com/ef4/prember-crawler) I tested the `_redirects` on netlify to confirm it will work, and it does. By default, prember outputs an `_empty.html` file that contains your original (empty) index.html content, since your pre-rendered index.html file will have actual content in it.
* Fix last set of tests * Add two more tests
* Remove dependency on ember-native-dom-helpers * Not used any more
|
Friendly bump here to see when this is able to be merged. Thanks 👍 |
|
@alexdiliberto can you rebase this over master? I think tests should be green after that. |
… into patch-1 * 'patch-1' of github.com:alexdiliberto/ember-power-select: Test: Add a couple missing tests for power-select-multiple with custom components Fix: add extra hash to power-select-multiple selectedItemComponent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1074
Also added a few missing tests that I noticed were needed